Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyqt5: 5.15.9 -> 5.15.10 #325893

Merged
merged 1 commit into from
Jul 10, 2024
Merged

pyqt5: 5.15.9 -> 5.15.10 #325893

merged 1 commit into from
Jul 10, 2024
+2 −2

Conversation

Mrmaxmeier
Copy link
Contributor

@Mrmaxmeier Mrmaxmeier commented Jul 9, 2024 •
edited
Loading

The release announcement mentions that Python 3.12 is now supported:
https://www.riverbankcomputing.com/pipermail/pyqt/2023-October/045542.html

Without this update I'm seeing a segfault when trying to import PyQt5 on Python 3.12.

Resolves #325804, resolves #326048, resolves #325946

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
    • "3726 packages updated". I'll let OfBorg chew through these...
  • Tested basic functionality: tested and built the git-cola GUI while submitting this PR

@Mrmaxmeier Mrmaxmeier mentioned this pull request Jul 9, 2024
Closed
@ofborg ofborg bot requested a review from svanderburg July 9, 2024 18:12
@Mrmaxmeier Mrmaxmeier mentioned this pull request Jul 10, 2024
Open
@Mrmaxmeier
Copy link
Contributor Author

cc @NickCao @K900 who did the last PyQt (6) update 🙂

Note: It might be useful to backport this update since it'll also affect users on the stable channels who explicitly choose Python 3.12 for their applications.

@K900
Copy link
Contributor

K900 commented Jul 10, 2024

Needs to be retargeted to staging (make sure to draft the PR while you do that to avoid mass pings), otherwise LGTM.

@Mrmaxmeier Mrmaxmeier marked this pull request as draft July 10, 2024 15:24
@Mrmaxmeier Mrmaxmeier changed the base branch from master to staging July 10, 2024 15:25
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: printing 6.topic: policy discussion 6.topic: vim 6.topic: ocaml 6.topic: stdenv Standard environment 6.topic: pantheon The Pantheon desktop environment 6.topic: lua 6.topic: cinnamon Desktop environment 6.topic: vscode 6.topic: lib The Nixpkgs function library 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: dotnet Language: .NET labels Jul 10, 2024
@github-actions github-actions bot removed 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: printing 6.topic: policy discussion 6.topic: vim 6.topic: ocaml 6.topic: stdenv Standard environment 6.topic: pantheon The Pantheon desktop environment 6.topic: lua 6.topic: cinnamon Desktop environment 6.topic: vscode 6.topic: lib The Nixpkgs function library 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: dotnet Language: .NET labels Jul 10, 2024
@K900 K900 merged commit 520ba7d into NixOS:staging Jul 10, 2024
23 checks passed
@Mrmaxmeier
Copy link
Contributor Author

Thanks!

@Mrmaxmeier Mrmaxmeier deleted the pyqt5-update-5.15.10 branch July 10, 2024 18:38
@linsui linsui mentioned this pull request Jul 12, 2024
Merged
13 tasks
This was referenced Jul 12, 2024
Closed
Closed
@minijackson minijackson mentioned this pull request Jul 18, 2024
Closed
@eclairevoyant eclairevoyant mentioned this pull request Jul 23, 2024
Closed
doronbehar added a commit to doronbehar/nixpkgs that referenced this pull request Aug 16, 2024
@doronbehar
picard: switch back to Python 3.12
9e0678b 
PR NixOS#325893 has reached `master` branch, so the pyqt5 issue with Python
3.12 is no longer an issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: vimiv-qt Build failure: picard Build failure: git-cola
2 participants
@Mrmaxmeier @K900