Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] gitu: 0.20.1 -> 0.22.1 #325850

Closed
wants to merge 3 commits into from
Closed

[24.05] gitu: 0.20.1 -> 0.22.1 #325850

wants to merge 3 commits into from

Conversation

eclairevoyant
Copy link
Contributor

@eclairevoyant eclairevoyant commented Jul 9, 2024

Description of changes

Backports of #320401, #322088, #325080

based on https://github.com/altsem/gitu/releases it seems these are all bugfix + new-feature releases and eligible for backport

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@evanrichter
Copy link
Contributor

0.21.0 and 0.22.0 both have features added, but they seem additive in nature, and probably are backwards compatible.

Since the application is TUI focused, there probably aren't exotic uses in shell scripts.

@eclairevoyant
Copy link
Contributor Author

0.21.0 and 0.22.0 both have features added,

Thanks for catching, edited

@eclairevoyant
Copy link
Contributor Author

??

@evanrichter
Copy link
Contributor

Story, I just don't have the bandwidth right now to rule out the impact of backporting this.

It's easy enough to opt in to the latest version with overlays, so I suggest anyone who wants the latest gitu on stable NixOS to use that method.

@eclairevoyant
Copy link
Contributor Author

Then someone else with bandwidth should review.

@eclairevoyant eclairevoyant reopened this Jul 15, 2024
@eclairevoyant eclairevoyant deleted the gitu-backport branch September 10, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants