Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decklink: init at 14.0.1a2 #325811

Merged
merged 2 commits into from
Jul 15, 2024
Merged

decklink: init at 14.0.1a2 #325811

merged 2 commits into from
Jul 15, 2024

Conversation

Naxdy
Copy link
Contributor

@Naxdy Naxdy commented Jul 9, 2024 •
edited
Loading

Description of changes

Taking over as maintainer after hexchen's departure (see #324101 for context)

Also updated to latest version. PR still pending local tests on actual hardware on my side, but so far everything builds.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 9, 2024
@Naxdy Naxdy force-pushed the work/blackmagic branch from c43a0fa to 58255de Compare July 9, 2024 11:18
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jul 9, 2024
@Naxdy Naxdy force-pushed the work/blackmagic branch from 58255de to 4d222ac Compare July 9, 2024 21:38
@Naxdy Naxdy marked this pull request as ready for review July 9, 2024 21:38
@Naxdy
Copy link
Contributor Author

Naxdy commented Jul 9, 2024

My DeckLink Mini Recorder works in OBS.

@quikssb
Copy link

quikssb commented Jul 14, 2024

Would love to have this merged soon! @AndersonTorres @SuperSandro2000
Thanks.

AndersonTorres
AndersonTorres reviewed Jul 14, 2024
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naxdy Naxdy force-pushed the work/blackmagic branch from 4d222ac to 73ffe01 Compare July 14, 2024 18:43
@Naxdy Naxdy requested a review from SuperSandro2000 July 14, 2024 20:39
@SuperSandro2000 SuperSandro2000 merged commit 99fe524 into NixOS:master Jul 15, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Naxdy @quikssb @AndersonTorres @SuperSandro2000