Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyprlandPlugins.hyprscroller: init at 0-unstable-2024-07-04 #325389

Merged
merged 1 commit into from
Jul 9, 2024
Merged

hyprlandPlugins.hyprscroller: init at 0-unstable-2024-07-04 #325389

merged 1 commit into from
Jul 9, 2024

Conversation

donovanglover
Copy link
Member

Description of changes

Adds https://github.com/dawsers/hyprscroller

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@donovanglover donovanglover requested a review from fufexan July 8, 2024 01:22
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 8, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 8, 2024
JohnRTitor
JohnRTitor reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase.

@donovanglover donovanglover requested a review from JohnRTitor July 9, 2024 04:58
JohnRTitor
JohnRTitor approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use unstableGitUpdater for these?

@JohnRTitor JohnRTitor mentioned this pull request Jul 9, 2024
Merged
13 tasks
@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 325389 run on x86_64-linux 1

1 package built:
  • hyprlandPlugins.hyprscroller

@donovanglover
Copy link
Member Author

Good idea added

@JohnRTitor JohnRTitor merged commit d29ed7a into NixOS:master Jul 9, 2024
24 of 26 checks passed
@donovanglover donovanglover deleted the hyprscroller branch August 2, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnRTitor JohnRTitor JohnRTitor approved these changes

@fufexan fufexan fufexan approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donovanglover @JohnRTitor @fufexan @wegank