Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coredns: 1.11.1 -> 1.11.3 #325373

Merged
merged 2 commits into from
Jul 10, 2024
Merged

coredns: 1.11.1 -> 1.11.3 #325373

merged 2 commits into from
Jul 10, 2024

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jul 7, 2024 •
edited
Loading

Description of changes

https://nvd.nist.gov/vuln/detail/CVE-2024-0874

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@risicle risicle added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.05 labels Jul 7, 2024
@ofborg ofborg bot requested review from DeltaEvo, rtreffer and rushmorem July 8, 2024 00:43
@risicle risicle force-pushed the ris-coredns-1.11.3 branch from 46aa9a0 to ab94fd2 Compare July 8, 2024 21:04
@risicle risicle force-pushed the ris-coredns-1.11.3 branch from ab94fd2 to 21e4330 Compare July 8, 2024 22:28
@risicle risicle force-pushed the ris-coredns-1.11.3 branch from 21e4330 to ceeb0dc Compare July 8, 2024 23:21
@risicle risicle marked this pull request as ready for review July 8, 2024 23:45
LeSuisse
LeSuisse approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the build on Linux aarch64.

Thanks for adding passthru.tests!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 10, 2024
@risicle risicle merged commit e166a7b into NixOS:master Jul 10, 2024
33 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Jul 10, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeSuisse LeSuisse LeSuisse approved these changes

@DeltaEvo DeltaEvo Awaiting requested review from DeltaEvo

@rtreffer rtreffer Awaiting requested review from rtreffer

@rushmorem rushmorem Awaiting requested review from rushmorem

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@risicle @LeSuisse @wegank