Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanomq: 0.20.8 → 0.22.1 #325328

Merged
merged 3 commits into from
Aug 25, 2024
Merged

nanomq: 0.20.8 → 0.22.1 #325328

merged 3 commits into from
Aug 25, 2024

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jul 7, 2024

Description of changes

https://nvd.nist.gov/vuln/detail/CVE-2024-25767
https://nvd.nist.gov/vuln/detail/CVE-2024-31040
https://nvd.nist.gov/vuln/detail/CVE-2024-31041
https://nvd.nist.gov/vuln/detail/CVE-2024-31036

Replacement for #284345. Turns out even if I hack a version of paho-mqtt 2.x into the PYTHONPATH here, the websocket tests still fail. So, omit them because we can't continue shipping a package with these vulnerabilities. Unless we're going to just leave it and mark with knownVulnerabilities, which is also an option.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@smancill
Copy link
Contributor

Result of nixpkgs-review pr 325328 run on x86_64-darwin 1

1 package built:
  • nanomq

@smancill smancill added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 16, 2024
@smancill
Copy link
Contributor

@ofborg build nanomq

@vcunat
Copy link
Member

vcunat commented Aug 22, 2024

nanomq.tests were broken before this PR already, but the error message changed 😕

disable websocket install-checks for now, as it seems properly
broken
@smancill
Copy link
Contributor

smancill commented Aug 24, 2024

Result of nixpkgs-review pr 325328 run on x86_64-darwin 1

1 package built:
  • nanomq

The installCheckPhase does fail though, with the same interruption error than in Linux.

@smancill
Copy link
Contributor

Also, I noticed this:

nanomq>           ************************************************************
nanomq>           Linking against Mbed TLS may change license terms.
nanomq>           Consult a lawyer and the license files for details.
nanomq>           ************************************************************

@risicle risicle merged commit 7849cd4 into NixOS:master Aug 25, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants