-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nanomq: 0.20.8 → 0.22.1 #325328
Merged
Merged
nanomq: 0.20.8 → 0.22.1 #325328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risicle
added
the
1.severity: security
Issues which raise a security issue, or PRs that fix one
label
Jul 7, 2024
13 tasks
Result of 1 package built:
|
smancill
approved these changes
Aug 16, 2024
smancill
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Aug 16, 2024
@ofborg build nanomq |
|
smancill
reviewed
Aug 22, 2024
disable websocket install-checks for now, as it seems properly broken
risicle
force-pushed
the
ris-nanomq-0.22
branch
from
August 24, 2024 12:24
add78bd
to
36731fc
Compare
Result of 1 package built:
The |
Also, I noticed this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1.severity: security
Issues which raise a security issue, or PRs that fix one
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
12.approvals: 1
This PR was reviewed and approved by one reputable person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://nvd.nist.gov/vuln/detail/CVE-2024-25767
https://nvd.nist.gov/vuln/detail/CVE-2024-31040
https://nvd.nist.gov/vuln/detail/CVE-2024-31041
https://nvd.nist.gov/vuln/detail/CVE-2024-31036
Replacement for #284345. Turns out even if I hack a version of paho-mqtt 2.x into the
PYTHONPATH
here, the websocket tests still fail. So, omit them because we can't continue shipping a package with these vulnerabilities. Unless we're going to just leave it and mark withknownVulnerabilities
, which is also an option.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.