Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: clean up pythonRelaxDepsHook references #325283

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Jul 7, 2024

Referencing it is not necessary any more, since using pythonRelaxDeps
or pythonRemoveDeps will automatically make sure the hook is provided.## Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Referencing it is not necessary any more, since using pythonRelaxDeps
or pythonRemoveDeps will automatically make sure the hook is provided.
@mweinelt
Copy link
Member Author

mweinelt commented Jul 7, 2024

Huh, rebuilds. Editing the hook 🤷

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jul 7, 2024
@mweinelt mweinelt force-pushed the python-relax-deps-hook-cleanup branch from 1d7fbf7 to 6b8de6b Compare July 7, 2024 20:37
@mweinelt mweinelt merged commit 9887372 into NixOS:master Jul 7, 2024
24 checks passed
@mweinelt mweinelt deleted the python-relax-deps-hook-cleanup branch July 7, 2024 23:12
@superherointj superherointj mentioned this pull request Jul 10, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants