swiProlog: 9.1.21 -> 9.2.5

[matko]

Description of changes

This upgrades SWI-Prolog to the latest stable. See the changelog for more details.

Note that it appears to have been established practice in this package to import a development version of the SWI-Prolog source, though I haven't been able to find an indication that this was intentional. I am intentionally upgrading to a stable version instead, with the hope that from now on, this package will track SWI-Prolog stable.

SWI-Prolog stable versions only receive backported fixes after release, whereas in the development versions, anything goes, including backwards-incompatible breaks with previous versions of the same minor number. This means stable is suitable for doing backports to released versions of nixpkgs, while the development version is not.

I left some comments in the package source to point this out, in the hope that future importers will not accidentally pull in a dev version.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[meditans]

LGTM, but please tag the person who originally made the switch to swipl-devel (that you reverted) and see what was the reason for doing that

[matko]

@barakber according to git history you originally upgraded swi-prolog from 7.6.4 to 8.1.4 back in 2019 (990acf7), along with various improvements to the packaging. This switched the version of swi-prolog in nixpkgs from stable to devel.

In this PR I am going back to tracking stable. I think it makes more sense to track stable, as this allows more easy backporting of fixes. Since we're going from 9.1.21 to 9.2.5, this should be a mostly clean upgrade path for people (as clean as it can be from a development version anyway).
I wasn't really sure why this change to use devel was made in the first place. Do you remember? And do you have objections to this switch back to stable?

[AndersonTorres]

Why not both? A swiprolog-devel for those who like it, and swiprolog as the stable.

[matko]

I'm fine with both. But I feel strongly that the default should be stable.

Also, I don't think this PR has to be held up until that is implemented. Nobody really loses anything in this move to stable. People who might have relied on features under development in 9.1 will find these features stabilized in 9.2. Luckily 9.1.21 is pretty late in the dev cycle so it should be pretty close already.

[AndersonTorres]

You are correct.