Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceptre: move to by-name; add license field; cleanup; update to 0-unstable-2024-8-26 #325113

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

NotAShelf
Copy link
Member

@NotAShelf NotAShelf commented Jul 6, 2024

Description of changes

Cleans up derivation for Ceptre, adds license, formats via nixfmt-rfc-style and
updates to the latest untagged commit: 0-unstable-2023-12-12

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See
    Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using
    nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all
    changes have to be committed, also see
    nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in
    ./result/bin/)
  • 24.11 Release Notes
    (or backporting
    23.11
    and
    24.05
    Release notes)
    • (Package updates) Added a release notes entry if the change is major or
      breaking
    • (Module updates) Added a release notes entry if the change is
      significant
    • (Module addition) Added a release notes entry if adding a new NixOS
      module
  • Fits
    CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NotAShelf NotAShelf force-pushed the cl-ceptre branch 4 times, most recently from 12c73d5 to 8a0eef8 Compare July 6, 2024 20:01
@NotAShelf NotAShelf marked this pull request as draft July 6, 2024 20:01
@NotAShelf NotAShelf marked this pull request as ready for review July 6, 2024 20:11
@ofborg ofborg bot requested a review from pSub July 6, 2024 21:22
Copy link
Member

@Frontear Frontear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that rev bumping of this can be automated via a passthru.updateScript { }? Would be great so that it doesn't require manual bumping, especially if its a simple drv

@Frontear
Copy link
Member

Frontear commented Jul 7, 2024

Result of nixpkgs-review pr 325113 run on x86_64-linux 1

1 package built:
  • ceptre

@NotAShelf
Copy link
Member Author

Is it possible that rev bumping of this can be automated via a passthru.updateScript { }? Would be great so that it doesn't require manual bumping, especially if its a simple drv

You mean to undo updating, let the update bot handle it?

@Frontear
Copy link
Member

Frontear commented Jul 7, 2024

Is it possible that rev bumping of this can be automated via a passthru.updateScript { }? Would be great so that it doesn't require manual bumping, especially if its a simple drv

You mean to undo updating, let the update bot handle it?

No no, this PR is great and should get merged. My comment meant moreso that in this PR, as part of the cleanup, maybe we can add an updateScript, assuming its possible

@NotAShelf
Copy link
Member Author

It should be easy to do, I'll handle that tomorrow.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@Pandapip1 Pandapip1 added the 1.severity: legal This PR or issue raises or fixes a legal issue, e.g. licensing compliance label Nov 6, 2024
@SuperSandro2000
Copy link
Member

Please rebase

@NotAShelf NotAShelf changed the title ceptre: move to by-name; add license field; cleanup; update to 0-unstable-2023-12-12 ceptre: move to by-name; add license field; cleanup; update to 0-unstable-2024-8-26 Nov 8, 2024
@NotAShelf
Copy link
Member Author

I had missed that, done.

@NotAShelf
Copy link
Member Author

Formatting is fixed too now.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 8, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 8, 2024
@Pandapip1 Pandapip1 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@Pandapip1
Copy link
Contributor

Merge conflict due to #354531.

@NotAShelf
Copy link
Member Author

That was... unexpected. I'll try to fix it tomorrow.

@NotAShelf
Copy link
Member Author

Okay that was faster than I thought. @Pandapip1 I hope this is satisfactory?

@Pandapip1
Copy link
Contributor

image

LGTM

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 10, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
Add myself as a maintainer so that I'm made aware of future updates, and get rid of nested `with lib`
@niklaskorz
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 325113


aarch64-darwin

✅ 1 package built:
  • ceptre

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2182

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 3, 2025
@Atemu Atemu merged commit 7491cae into NixOS:master Jan 3, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: legal This PR or issue raises or fixes a legal issue, e.g. licensing compliance 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants