-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceptre: move to by-name; add license field; cleanup; update to 0-unstable-2024-8-26 #325113
Conversation
12c73d5
to
8a0eef8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that rev bumping of this can be automated via a passthru.updateScript { }
? Would be great so that it doesn't require manual bumping, especially if its a simple drv
Result of 1 package built:
|
You mean to undo updating, let the update bot handle it? |
No no, this PR is great and should get merged. My comment meant moreso that in this PR, as part of the cleanup, maybe we can add an updateScript, assuming its possible |
It should be easy to do, I'll handle that tomorrow. |
Please rebase |
I had missed that, done. |
Formatting is fixed too now. |
Merge conflict due to #354531. |
That was... unexpected. I'll try to fix it tomorrow. |
Okay that was faster than I thought. @Pandapip1 I hope this is satisfactory? |
Add myself as a maintainer so that I'm made aware of future updates, and get rid of nested `with lib`
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2182 |
Description of changes
Cleans up derivation for Ceptre, adds license, formats via nixfmt-rfc-style and
updates to the latest untagged commit: 0-unstable-2023-12-12
Things done
nix.conf
? (SeeNix manual)
sandbox = relaxed
sandbox = true
(look inside
nixos/tests)
package tests
lib/tests or
pkgs/test
linked
to the relevant packages
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: allchanges have to be committed, also see
nixpkgs-review usage
./result/bin/
)(or backporting
23.11
and
24.05
Release notes)
breaking
significant
module
CONTRIBUTING.md.
Add a 👍 reaction to pull requests you find important.