-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inko: init at 0.15.0 & ivm: init at 0.5.0 #325089
Conversation
|
||
wrapProgram $out/bin/ivm \ | ||
--prefix PATH : ${lib.makeBinPath [ cargo llvm_16.dev stdenv.cc ]} \ | ||
--prefix LIBRARY_PATH : ${lib.makeLibraryPath [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--prefix LIBRARY_PATH : ${lib.makeLibraryPath [ | |
--prefix LD_LIBRARY_PATH : ${lib.makeLibraryPath [ |
? Not sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LD_LIBRARY_PATH
doesn't work here, but LIBRARY_PATH
probably isn't the best option either.
Afaik, LD_LIBRARY_PATH
specifies where to find libraries at runtime, but the libraries provided here are needed at build-time (not the build-time of ivm
itself, but the time when ivm
builds inko
).
I dislike using LIBRARY_PATH
here because it seems to be a gcc specific variable, but I don't know how else to achieve this, and at least this way ivm
works the way it's supposed to (i.e. ivm install latest
downloads and builds the latest inko
version, compiled with all the right dependencies and libraries).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried on x86_64-linux
, was able to run a simple program, LGTM
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-summer-of-nix-program-updates/46053/4 |
Per NixOS/nixpkgs#325089, Inko and ivm are now available to Nix users.
Description of changes
This adds Inko, a programming language for building concurrent software and its version manager, ivm.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.