Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inko: init at 0.15.0 & ivm: init at 0.5.0 #325089

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

feathecutie
Copy link
Contributor

Description of changes

This adds Inko, a programming language for building concurrent software and its version manager, ivm.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jul 6, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 6, 2024
pkgs/by-name/in/inko/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/inko/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/inko/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/inko/package.nix Outdated Show resolved Hide resolved

wrapProgram $out/bin/ivm \
--prefix PATH : ${lib.makeBinPath [ cargo llvm_16.dev stdenv.cc ]} \
--prefix LIBRARY_PATH : ${lib.makeLibraryPath [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--prefix LIBRARY_PATH : ${lib.makeLibraryPath [
--prefix LD_LIBRARY_PATH : ${lib.makeLibraryPath [

? Not sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LD_LIBRARY_PATH doesn't work here, but LIBRARY_PATH probably isn't the best option either.
Afaik, LD_LIBRARY_PATH specifies where to find libraries at runtime, but the libraries provided here are needed at build-time (not the build-time of ivm itself, but the time when ivm builds inko).
I dislike using LIBRARY_PATH here because it seems to be a gcc specific variable, but I don't know how else to achieve this, and at least this way ivm works the way it's supposed to (i.e. ivm install latest downloads and builds the latest inko version, compiled with all the right dependencies and libraries).

pkgs/by-name/iv/ivm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/iv/ivm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/iv/ivm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/iv/ivm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/inko/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@JulienMalka JulienMalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried on x86_64-linux, was able to run a simple program, LGTM

@JulienMalka JulienMalka merged commit fa4b81d into NixOS:master Aug 8, 2024
27 checks passed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-summer-of-nix-program-updates/46053/4

yorickpeterse added a commit to inko-lang/inko that referenced this pull request Aug 15, 2024
Per NixOS/nixpkgs#325089, Inko and ivm are now
available to Nix users.
@feathecutie feathecutie deleted the inko branch August 20, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants