Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Package.ssort: init at 0.13.0 #324722

Merged
merged 1 commit into from
Jul 10, 2024
Merged

python312Package.ssort: init at 0.13.0 #324722

merged 1 commit into from
Jul 10, 2024

Conversation

Tochiaha
Copy link
Contributor

@Tochiaha Tochiaha commented Jul 5, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Tochiaha Tochiaha requested a review from natsukium as a code owner July 5, 2024 04:48
@Tochiaha Tochiaha changed the title python312Package.sort: init at 0.13.0 python312Package.ssort: init at 0.13.0 Jul 5, 2024
@Tochiaha Tochiaha force-pushed the ssort branch 2 times, most recently from 0a6aecd to 1d1d575 Compare July 5, 2024 05:07
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 5, 2024
@Tochiaha Tochiaha force-pushed the ssort branch 2 times, most recently from aeca37d to 8b06955 Compare July 5, 2024 06:41
@Tochiaha Tochiaha closed this Jul 5, 2024
@Tochiaha Tochiaha reopened this Jul 5, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Jul 5, 2024
@Tochiaha
Copy link
Contributor Author

Tochiaha commented Jul 7, 2024

@fabaff

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4208

@Tochiaha Tochiaha mentioned this pull request Jul 8, 2024
Closed
13 tasks
Sigmanificient
Sigmanificient suggested changes Jul 9, 2024
View reviewed changes
pkgs/development/python-modules/ssort/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/ssort/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/ssort/default.nix Outdated Show resolved Hide resolved
@Tochiaha Tochiaha force-pushed the ssort branch 2 times, most recently from 7bd5fa7 to 6950187 Compare July 9, 2024 18:01
@Tochiaha
Copy link
Contributor Author

@superherointj

@superherointj
Copy link
Contributor

Result of nixpkgs-review pr 324722 run on aarch64-darwin 1

4 packages built:
  • python311Packages.ssort
  • python311Packages.ssort.dist
  • python312Packages.ssort
  • python312Packages.ssort.dist

@NixOS NixOS deleted a comment from nixos-discourse Jul 10, 2024
@superherointj superherointj merged commit f83c98d into NixOS:master Jul 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium left review comments

@Sigmanificient Sigmanificient Sigmanificient requested changes

@superherointj superherointj superherointj approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tochiaha @nixos-discourse @superherointj @natsukium @Sigmanificient