catppuccin-gtk: fix inconsistent theme name

[eljamm]

Description of changes

The theme name uses default as fallback for tweaks when they aren't set, which not only is not a valid tweak name, but can lead to confusion and inconsistencies.

As such, we can either replace "default" with "normal", or we can just remove tweaks from the theme name if the list is empty.
The advantage of the second approach is that users won't have to worry about which tweak name they have to specify by default, which also looks cleaner:

    # before
    gtk.theme.name = "catppuccin-macchiato-pink-compact+default";

    # after
    gtk.theme.name = "catppuccin-macchiato-pink-compact";

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[isabelroses]

This seems reasonable but my only issue is that now we are deferring from upstream which also adds to the confusion. I mean even I got confused by this, and I've done some work on ctp gtk

[eljamm]

We can't really do much there since upstream was archived, but it doesn't make sense to leave it as it is now either as default is not a valid tweak.

[isabelroses]

Sounds good, added backport to make catppuccin/nix's life a bit easier

[github-actions]

Successfully created backport PR for release-24.05:

• [Backport release-24.05] catppuccin-gtk: fix inconsistent theme name #324307

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/gtk-settings-suddenly-not-applying/47381/13