Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stash: refactor; 0.25.1 -> 0.27.2; nixos/stash: init #323231

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DrakeTDL
Copy link

@DrakeTDL DrakeTDL commented Jun 28, 2024

Description of changes

This Pull Request:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jun 28, 2024
@DrakeTDL DrakeTDL force-pushed the stash branch 7 times, most recently from 1e88836 to 42d1ca5 Compare June 29, 2024 07:37
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Jun 29, 2024
@DrakeTDL DrakeTDL force-pushed the stash branch 3 times, most recently from 4206b75 to 1d0a178 Compare June 30, 2024 05:16
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Jul 1, 2024
@DrakeTDL DrakeTDL force-pushed the stash branch 2 times, most recently from 27ac7fd to 2687ded Compare July 6, 2024 02:00
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 6, 2024
@DrakeTDL DrakeTDL force-pushed the stash branch 2 times, most recently from a7f641e to b9ae77c Compare July 6, 2024 03:30
@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Jul 13, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 13, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 13, 2024
@phanirithvij

This comment was marked as outdated.

};
})
}).overrideAttrs
Copy link
Member

@phanirithvij phanirithvij Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason for this overrideAttrs? can put passthru in buildGoModule itself.

also maybe add passthru.frontend = ui; so people have the ability to override ui build from outside. eg.

and https://github.com/phanirithvij/system/blob/eca1177e783d5a513ee380892e3ac54dbafff63a/nixos/applications/opengist.nix#L74

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason for this overrideAttrs? can put passthru in buildGoModule itself.

I initially did that because buildGoModule didn't accept a fixed-point function and I didn't think that I could request itself from the arguments. Don't know why I thought that since it is a package like any other.

As suggested, I inlined passthru and inherited frontend.

@phanirithvij phanirithvij added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 27, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1 and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 27, 2024
@FliegendeWurst FliegendeWurst changed the title Stash: refactor; 0.25.1 -> 0.27.2; nixos/stash: init stash: refactor; 0.25.1 -> 0.27.2; nixos/stash: init Dec 29, 2024
@@ -129,6 +129,8 @@

- [Dashy](https://dashy.to), an open source, highly customizable, easy to use, privacy-respecting dashboard app. Available as [services.dashy](options.html#opt-services.dashy).

- [Stash](https://github.com/stashapp/stash), An organizer for your adult videos/images, written in Go. Available as [services.stash](#opt-services.stash.enable).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the 24.11 notes, so you want a backport, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the 24.11 notes

I forgot to move that line to the current release.

so you want a backport, right?

Not necessarily, while that may be nice to have, my goal is to get the refactored package (and module) into the current release.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 13, 2025
DrakeTDL and others added 4 commits January 13, 2025 11:36
Uses git source directly instead of binary releases
Adds an update script
Adds a version test
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants