-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stash: refactor; 0.25.1 -> 0.27.2; nixos/stash: init #323231
base: master
Are you sure you want to change the base?
Conversation
1e88836
to
42d1ca5
Compare
4206b75
to
1d0a178
Compare
27ac7fd
to
2687ded
Compare
a7f641e
to
b9ae77c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
pkgs/by-name/st/stash/package.nix
Outdated
}; | ||
}) | ||
}).overrideAttrs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any particular reason for this overrideAttrs? can put passthru
in buildGoModule itself.
also maybe add passthru.frontend = ui;
so people have the ability to override ui build from outside. eg.
inherit frontend; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any particular reason for this overrideAttrs? can put
passthru
in buildGoModule itself.
I initially did that because buildGoModule didn't accept a fixed-point function and I didn't think that I could request itself from the arguments. Don't know why I thought that since it is a package like any other.
As suggested, I inlined passthru
and inherited frontend.
@@ -129,6 +129,8 @@ | |||
|
|||
- [Dashy](https://dashy.to), an open source, highly customizable, easy to use, privacy-respecting dashboard app. Available as [services.dashy](options.html#opt-services.dashy). | |||
|
|||
- [Stash](https://github.com/stashapp/stash), An organizer for your adult videos/images, written in Go. Available as [services.stash](#opt-services.stash.enable). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in the 24.11 notes, so you want a backport, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in the 24.11 notes
I forgot to move that line to the current release.
so you want a backport, right?
Not necessarily, while that may be nice to have, my goal is to get the refactored package (and module) into the current release.
Uses git source directly instead of binary releases Adds an update script Adds a version test
Description of changes
This Pull Request:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.