Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 322886 to release 24.05 #323008

Merged

Conversation

fricklerhandwerk
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk commented Jun 27, 2024

Description of changes

Combined minor bumps and fix 2.23 build:

#322886
#322977

@nixos/nix-team

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 27, 2024
@ofborg ofborg bot requested review from flokli, lovesegfault and edolstra June 27, 2024 21:13
@roberth
Copy link
Member

roberth commented Jun 28, 2024

@ofborg build nix
@ofborg build nixVersions.nix_2_18
@ofborg build nixVersions.nix_2_19
@ofborg build nixVersions.nix_2_20
@ofborg build nixVersions.nix_2_21
@ofborg build nixVersions.nix_2_22
@ofborg build nixVersions.nix_2_23

@roberth
Copy link
Member

roberth commented Jun 28, 2024

Oh, we don't have 2.23 yet?

ofborg's darwin builds are slow, but a few have succeeded, so I'm fairly confident the rest of them will be ok. Let's get this into the channel.

@roberth roberth merged commit 8a59ac5 into NixOS:release-24.05 Jun 28, 2024
43 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants