Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] python3Packages.amaranth-soc: fix fetchFromGitHub hash stability #321799

Merged

Conversation

tpwrules
Copy link
Contributor

cc @pbsds @mweinelt

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from thoughtpolice and emilazy June 22, 2024 17:33
@tpwrules tpwrules changed the title python3Packages.amaranth-soc: fix fetchFromGitHub hash stability [23.11] python3Packages.amaranth-soc: fix fetchFromGitHub hash stability Jun 23, 2024
@tpwrules
Copy link
Contributor Author

tpwrules commented Jun 23, 2024

Same issue as #321796, just a different package (amaranth-boards is not affected at its revision in 23.11).

@pbsds
Copy link
Member

pbsds commented Jun 23, 2024

@ofborg build python311Packages.amaranth-soc python310Packages.amaranth-soc python311Packages.amaranth-soc.passthru.tests python310Packages.amaranth-soc.passthru.tests

@pbsbot
Copy link

pbsbot commented Jun 24, 2024

Result of nixpkgs-review pr 321799 run on x86_64-linux 1

4 packages built:
  • python310Packages.amaranth-soc
  • python310Packages.amaranth-soc.dist
  • python311Packages.amaranth-soc
  • python311Packages.amaranth-soc.dist

@pbsds pbsds merged commit 90bd1b2 into NixOS:release-23.11 Jun 24, 2024
28 of 29 checks passed
@tpwrules tpwrules deleted the pr/amaranth-hash-stability-23.11 branch June 25, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants