Re-add grab-site with updates to dependencies for python 3.12 #321601
Conversation
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
8.has: package (new)
| }: | ||
|
|
||
| buildPythonPackage { | ||
| with python.pkgs; buildPythonPackage { |
There was a problem hiding this comment.
can you explain the reason for this change ?
There was a problem hiding this comment.
Its packaging dependency needs it; In an upcoming commit I've removed the with python.pkgs and instead used python.pkgs.packaging as the dependency. Thanks.
|
Oh, I should probably cc @ivan as they were the original maintainer of these packages, I'm re-adding them after their removal, and as the are now, I didn't list a maintainer. Would you like me to add you back? |
|
Yes, I would like to be in the |
| defaultOverrides = [ | ||
| # override the version of packages pinned in pyproject.toml | ||
| (self: super: { | ||
| sqlalchemy = super.sqlalchemy.overridePythonAttrs (oldAttrs: rec { |
There was a problem hiding this comment.
overrides can not be done for python modules, because it would introduce clashes with other dependencies
overrides can be done for applications. from my initial look wpull is intended to be used as an application and not python module ( eg import )
if that's the case then it needs to be moved to by-name https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/README.md
There was a problem hiding this comment.
Moved, thanks. And thank for your patience.
| @@ -0,0 +1,47 @@ | |||
| { lib | |||
| , python312 | |||
There was a problem hiding this comment.
this should be set in all-packages.nix
There was a problem hiding this comment.
I believe I have addressed this one correctly. It's the main thing I doubt myself on regarding your latest feedback.
I didn't do it like your link instructs b/c it seemed like other packages in all-packages.nix with the same problem were using python312Packages.callPackage to solve it.
There was a problem hiding this comment.
... okay that didn't work. I've done it like these docs say. I finally figured out the right combo of python___ stuff.
|
@pastly so currently this PR causes a lot of rebuilds, which means it should target staging branch. staging already has tornado 6.4.1, so you can drop this patch to read more about branches workflow https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#staging please note a gotcha when changing target branch for a PR https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging |
Upstream's[0] requirements.txt files don't list it as a dependency, but it totally is one[1]. I hit a runtime error when trying to package ludios_wpull, which itself addresses[2] yapsy's dependency on packaging. 0: https://github.com/tibonihoo/yapsy 1: https://github.com/tibonihoo/yapsy/blob/6b487b04affb19ab40adbbc87827668bea0abcee/package/yapsy/PluginInfo.py#L16 2: https://github.com/ArchiveTeam/ludios_wpull/blob/f6cf1c3375d6722a742aa7e3dc463e528eaec906/pyproject.toml#L31
pastly
force-pushed
the
grab-site-and-reqs
branch
from
70f0dc3 to
d147bd7
Compare
ofborg
bot
added
2.status: merge conflict
|
tornado 6.4.1 is now on master, i recommend to target master for this PR don't forget the gotchata with changing target branches |
|
@pastly thanks for working on this, do you want someone else to take this up, or was it accidentally closed, or did you intend to make a new PR for |
The process was discouraging and I've temporarily/permanently tabled the project I was working on using these packages. No plans to make a PR for master, but anyone else is welcome to do so. |
Description of changes
Re-adds and bumps the version of ludios_wpull as necessary for grab-site to work with python 3.12. Consequently bumps tornado to 6.4 and adds
packagingas a dependency to yapsy (like it's supposed to be!).The ludios_wpull version update sounds huge, but it's just one real bump. No changelog in the project, but see release notes.
Tornado release notes page. It's only a bump of two versions. I stopped at 6.4.0 instead of going to 6.4.1 so that the nix mitmproxy tests wouldn't barf at a tornado version greater than 6.4 (I was running
nix-build -A pkgs.python3Packages.tornado.passthru.testsas docs suggested`)I'm running the above
passthru.testscommand now ... but it's seemingly going to take a long time since tornado is a popular library.Do I need to run it myself? Do I need to run it for more versions of python?
Thanks
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = true(it's Linux)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.