python311Packages.jaxlib: fix bazel hash #321559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of |
|
Result of |
ofborg
bot
added
10.rebuild-darwin: 0
|
Result of 36 packages marked as broken and skipped:
118 packages built:
|
|
Result of 36 packages marked as broken and skipped:
142 packages built:
|
|
I'm still confused why this was breaking in the first place... Do we have a sense of what's going on with these hashes? It seems that every once in a while we get a report that the hashes are wrong even though they build fine for others. |
No, unfortunately it is pretty unclear. |
wegank
added
the
12.approvals: 1
|
I'm also inclined to assume that hashes in |
|
Should we merge this fix at least ? |
|
I think so, but maybe we can also figure out what exactly causes this somehow |
natsukium
approved these changes
Jun 23, 2024
|
Looks like it's not over... |
|
@GaetanLepage please say you still have the previous FOD output cached and we can compare it with @drupol's 🙃 |
|
Note, I added this custom overlay: (self: super: {
openblas = super.openblas.overrideAttrs (oldAttrs: {
makeFlags = oldAttrs.makeFlags ++ [
"DEBUG=1"
];
});
})To try to debug a segfault with Openblas, do you think it might be the cause? Note2: I have no clue how to verify if that custom overlay could have an impact. |
|
@drupol ehhh if the FOD contained references to any other store paths I think we'd have noticed much earlier... but just technically, if you wanted to test for...
...you could just add some thrash into your openblas; just adding another argument beside |
I should still have a working one cached. |
|
|
@GaetanLepage can you build EDIT: if the |
Is it the reason why I struggle finding a way to update and fix the hash mismatch in a custom overlay ? |
No, this is just what makes it less convenient to debug. I'm pretty sure the reason starts with the letter "B". Gaetan just found a cached |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/building-openblas-with-debug-1-only-for-open-webui/47667/5 |
13 tasks
This comment has been minimized.
This comment has been minimized.
|
Reverting this PR won't fix it, since the hash you get now is a new one again. Something non-reproducible in the bazel build seems to change every few days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Should fix #296737...
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.