homebox: init at 0.13.0; nixos/homebox: init #320060
Merged
+211
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
8.has: package (new)
h7x4
added
8.has: module (new)
|
I should have addressed all your suggestions. Should be good now. |
ofborg
bot
added
10.rebuild-darwin: 0
ambroisie
reviewed
Jun 17, 2024
|
Fixed the commit messages and everything else. |
SuperSandro2000
requested changes
Jun 26, 2024
|
I think I have addressed all your comments. |
Airradda
reviewed
Jun 26, 2024
wegank
added
the
2.status: merge conflict
ofborg
bot
removed
the
2.status: merge conflict
|
I've fixed the double build by introducing an |
|
@PatrickDaG I merged that PR in last night :) |
PatrickDaG
force-pushed
the
homebox
branch
2 times, most recently
from
f97e96d to
ef2f780
Compare
PatrickDaG
changed the title
PatrickDaG
force-pushed
the
homebox
branch
2 times, most recently
from
30e904c to
13175dd
Compare
PatrickDaG
changed the title
SuperSandro2000
approved these changes
Aug 18, 2024
bjornfor
reviewed
Aug 18, 2024
bjornfor
reviewed
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added a new module for homebox.
This closes #309299 and would replace #273639 as that seems abandoned.
The project itself was archived a few days ago, but since it is currently still working perfectly fine I would not see this as blocking. I will keep looking if any promising forks turn up and might switch to that or if the project actually dies I will try to keep it working as long as I can, removing it if it turns out to be broken for good.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.