Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.inquirer: fix minimum Python version #320045

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

GetPsyched
Copy link
Member

Description of changes

Bump required Python version to match upstream (also Python 3.7 is deprecated), and bump package version

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GetPsyched GetPsyched marked this pull request as ready for review June 15, 2024 12:52
@GetPsyched
Copy link
Member Author

Irrespective of this PR, tests are failing for Python 3.8. Unsure if this is an upstream issue or something with the package.
cc @mmahut (package maintainer)

@wegank wegank force-pushed the python-inquirer branch from 687fbc0 to 9d99ba2 Compare July 6, 2024 18:36
@wegank wegank changed the title python3Packages.inquirer: 3.2.4 -> 3.2.5 python3Packages.inquirer: fix minimum Python version Jul 6, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jul 6, 2024
@SuperSandro2000 SuperSandro2000 merged commit 3203320 into NixOS:master Jul 6, 2024
25 checks passed
@GetPsyched GetPsyched deleted the python-inquirer branch July 7, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants