Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voicevox: init at 0.20.0 #319403

Merged
merged 3 commits into from
Dec 21, 2024
Merged

voicevox: init at 0.20.0 #319403

merged 3 commits into from
Dec 21, 2024

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Jun 12, 2024

Description of changes

Supersedes #287354

Homepage: https://voicevox.hiroshiba.jp
(I didn't put this homepage in the meta, since it's always 1 click away from the GitHub repo)


Note: downloading the voicevox_core prebuilt binaries takes a while.
Also note: the program's language is Japanese, so it might be difficult to navigate the program if you don't speak it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin (VM)
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@TomaSajt TomaSajt force-pushed the voicevox branch 5 times, most recently from 6e2b28e to f7e015f Compare June 12, 2024 23:13
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 13, 2024
@TomaSajt TomaSajt force-pushed the voicevox branch 4 times, most recently from 4913d5a to d36e2fd Compare June 13, 2024 19:04
@TomaSajt TomaSajt marked this pull request as ready for review June 14, 2024 17:32
@TomaSajt
Copy link
Contributor Author

TomaSajt commented Jun 14, 2024

For the record, before I add free = false: the CI seems to run fine
image

I didn't wait out aarch64-darwin, but I assume it's gonna build fine.

@TomaSajt TomaSajt mentioned this pull request Jun 14, 2024
13 tasks
@TomaSajt TomaSajt changed the title voicevox: init at 0.19.2 voicevox: init at 0.20.0 Aug 19, 2024
@TomaSajt TomaSajt force-pushed the voicevox branch 4 times, most recently from 3144dc9 to 73de990 Compare September 1, 2024 12:10
@TomaSajt TomaSajt force-pushed the voicevox branch 2 times, most recently from b7896fe to 7552e77 Compare September 29, 2024 21:08
@sarahec
Copy link
Contributor

sarahec commented Sep 29, 2024

Result of nixpkgs-review pr 319403 run on aarch64-darwin 1

3 packages failed to build:
  • voicevox-core
  • voicevox-engine
  • voicevox-engine.dist

@TomaSajt TomaSajt force-pushed the voicevox branch 5 times, most recently from 0a8d4e3 to 909e9ba Compare September 30, 2024 20:40
@TomaSajt
Copy link
Contributor Author

I pushed some small changes.

One of them was changing stdenv.is* to stdenv.hostPlatform.is*

The other change was using replaceVars instead of substituteAll.
This change made me realize that substituteAll wasn't actually substituting _7zz_path and was leaving it as @_7zz_path@. replaceVars actually worked, because its implementation is just a wrapper for substitute --replace-fail @key@ value.
I changed the variable name to be less confusing, now both methods should work.

@sarahec
Copy link
Contributor

sarahec commented Oct 1, 2024

Result of nixpkgs-review pr 319403 run on aarch64-darwin 1

3 packages built:
  • voicevox-core
  • voicevox-engine
  • voicevox-engine.dist

@sarahec sarahec self-requested a review October 1, 2024 16:59
@sarahec
Copy link
Contributor

sarahec commented Oct 1, 2024

Result of nixpkgs-review pr 319403 run on x86_64-linux 1

4 packages built:
  • voicevox
  • voicevox-core
  • voicevox-engine
  • voicevox-engine.dist

Copy link
Contributor

@sarahec sarahec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomaSajt
Copy link
Contributor Author

Anything else that needs to be done?

(btw, 0.21.0 is out, but I'll deal with that in a separate PR to see how easy it is to update.)

@eljamm
Copy link
Contributor

eljamm commented Dec 20, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 319403


x86_64-linux

❌ 3 packages failed to build:
  • voicevox
  • voicevox-engine
  • voicevox-engine.dist
✅ 1 package built:
  • voicevox-core

Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 319403


x86_64-linux

✅ 4 packages built:
  • voicevox
  • voicevox-core
  • voicevox-engine
  • voicevox-engine.dist

@eljamm eljamm added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 20, 2024
@eljamm
Copy link
Contributor

eljamm commented Dec 20, 2024

@ofborg build voicevox

@TomaSajt
Copy link
Contributor Author

@ofborg build voicevox

Won't build if unfree = true in voicevox-core

@TomaSajt
Copy link
Contributor Author

I haven't yet checked if the recent push actually works (some python package versions are different than expected), so please wait until I ensure everything's fine.

@TomaSajt
Copy link
Contributor Author

Okay, still seems to work

@eljamm
Copy link
Contributor

eljamm commented Dec 20, 2024

Thanks for testing. I was curious about this so I wanted to try it out too. Despite not understanding anything, I was somewhat able to navigate the interface, made a new project, created a "melody" and exported the result to a wav file. All in all, I think this is good to be merged.

@TomaSajt
Copy link
Contributor Author

Alright, I think I'll merge it sometime tomorrow.
There are version bumps available, but I'll make a different PR for those.

@TomaSajt TomaSajt merged commit 3add6c8 into NixOS:master Dec 21, 2024
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants