-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
voicevox: init at 0.20.0 #319403
voicevox: init at 0.20.0 #319403
Conversation
6e2b28e
to
f7e015f
Compare
4913d5a
to
d36e2fd
Compare
3144dc9
to
73de990
Compare
b7896fe
to
7552e77
Compare
Result of 3 packages failed to build:
|
0a8d4e3
to
909e9ba
Compare
I pushed some small changes. One of them was changing stdenv.is* to stdenv.hostPlatform.is* The other change was using |
Result of 3 packages built:
|
Result of 4 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Anything else that needs to be done? (btw, 0.21.0 is out, but I'll deal with that in a separate PR to see how easy it is to update.) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 319403
x86_64-linux
✅ 4 packages built:
- voicevox
- voicevox-core
- voicevox-engine
- voicevox-engine.dist
@ofborg build voicevox |
Won't build if unfree = true in voicevox-core |
I haven't yet checked if the recent push actually works (some python package versions are different than expected), so please wait until I ensure everything's fine. |
Okay, still seems to work |
Thanks for testing. I was curious about this so I wanted to try it out too. Despite not understanding anything, I was somewhat able to navigate the interface, made a new project, created a "melody" and exported the result to a wav file. All in all, I think this is good to be merged. |
Alright, I think I'll merge it sometime tomorrow. |
Description of changes
Supersedes #287354
Homepage: https://voicevox.hiroshiba.jp
(I didn't put this homepage in the meta, since it's always 1 click away from the GitHub repo)
Note: downloading the
voicevox_core
prebuilt binaries takes a while.Also note: the program's language is Japanese, so it might be difficult to navigate the program if you don't speak it.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.