-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kodiPackages.orftvthek: 0.12.12 -> 1.0.2+matrix.1 #318669
Conversation
looked at the diff and this update will require changes - marking as draft until myself or someone else can get around to it cc @dschrempf |
Hi @aanderse. Thanks for pulling me in. I tried to update the addon, it can be compiled and started in Kodi, but playing video files now requires a proprietary extension "Widevine". I was having a look and |
As I understand it, there must be two symlinks in |
c918928
to
4ab9cc6
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/s0faking/plugin.video.orftvthek/releases. meta.description for kodiPackages.orftvthek is: Addon that gives you access to the ORF TVthek Video Platform meta.homepage for kodiPackages.orftvthek is: https://github.com/s0faking/plugin.video.orftvthek Updates performed
To inspect upstream changesImpactChecks done
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 1 package built:
Maintainer pingscc @aanderse @cpages @dschrempf @edwtjo @nvmd @minijackson @peterhoeg @sephalon for testing. |
hmmm... so how does the |
OK, thanks for your suggestions and sorry letting you wait @aanderse and @nvmd. I managed to get the addon working, but:
Thanks for your help! |
i seen to recall using the
|
I see. I think I did not even click the "install widevine" stuff, but assumed it has to be done using Nix, and I managed doing so using links in my personal configuration. I can test if automatic install via Kodi is working, if this is preferred over adding those files using |
i assumed the exact opposite... your assumption leads to better results but takes more work how would it work to automate this? the links can exist in nix store? maybe we merge this the way it is but continue this conversation in another PR? what do you think? |
Sorry for the delay! I created a new PR superseding this one: #325934. |
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/s0faking/plugin.video.orftvthek/releases.
meta.description for kodiPackages.orftvthek is: Addon that gives you access to the ORF TVthek Video Platform
meta.homepage for kodiPackages.orftvthek is: https://github.com/s0faking/plugin.video.orftvthek
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }'
run on x86_64-linux 11 package built:
Maintainer pings
cc @aanderse @cpages @dschrempf @edwtjo @nvmd @minijackson @peterhoeg @sephalon for testing.