Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodiPackages.orftvthek: 0.12.12 -> 1.0.2+matrix.1 #318669

Closed

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/s0faking/plugin.video.orftvthek/releases.

meta.description for kodiPackages.orftvthek is: Addon that gives you access to the ORF TVthek Video Platform

meta.homepage for kodiPackages.orftvthek is: https://github.com/s0faking/plugin.video.orftvthek

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.0.2-1 in filename of file in /nix/store/vncrvk7czycihkwgm8fyrv5jzhmsjkzd-kodi-orftvthek-1.0.2-1

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

kodiPackages.orftvthek
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/vncrvk7czycihkwgm8fyrv5jzhmsjkzd-kodi-orftvthek-1.0.2-1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A kodiPackages.orftvthek https://github.com/r-ryantm/nixpkgs/archive/c918928d0a90a48565633b448fbcbaf9beb5ac6f.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/c918928d0a90a48565633b448fbcbaf9beb5ac6f#kodiPackages.orftvthek

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/vncrvk7czycihkwgm8fyrv5jzhmsjkzd-kodi-orftvthek-1.0.2-1
ls -la /nix/store/vncrvk7czycihkwgm8fyrv5jzhmsjkzd-kodi-orftvthek-1.0.2-1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:
  • kodiPackages.orftvthek

Maintainer pings

cc @aanderse @cpages @dschrempf @edwtjo @nvmd @minijackson @peterhoeg @sephalon for testing.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 10, 2024
@aanderse
Copy link
Member

looked at the diff and this update will require changes - marking as draft until myself or someone else can get around to it

cc @dschrempf

@dschrempf
Copy link
Contributor

Hi @aanderse. Thanks for pulling me in. I tried to update the addon, it can be compiled and started in Kodi, but playing video files now requires a proprietary extension "Widevine".

I was having a look and widevine-cdn is packaged in Nixpkgs because it is also required by Chromium when playing DRM content. Do you know how to integrate widevine-cdn into Kodi? Can I simply require the already existing package to be installed, or does it have to be integrated similar to the other Kodi dependencies?

@nvmd
Copy link
Member

nvmd commented Jun 12, 2024

Hi @aanderse. Thanks for pulling me in. I tried to update the addon, it can be compiled and started in Kodi, but playing video files now requires a proprietary extension "Widevine".

I was having a look and widevine-cdn is packaged in Nixpkgs because it is also required by Chromium when playing DRM content. Do you know how to integrate widevine-cdn into Kodi? Can I simply require the already existing package to be installed, or does it have to be integrated similar to the other Kodi dependencies?

As I understand it, there must be two symlinks in .kodi/cdm to files from widevine-cdm package: libwidevinecdm.so, and manifest.json.
This should be enough for inputstream-adaptive and inputstream-adaptive-helper to detect and use it for playback, I guess this should be the case for orftvthek as well.
Disclaimer: this didn't quite work for me on aarch64-linux even with inputstream-adaptive (but I think version mismatch is to blame).

@r-ryantm r-ryantm force-pushed the auto-update/kodiPackages.orftvthek branch from c918928 to 4ab9cc6 Compare June 18, 2024 02:45
@r-ryantm r-ryantm changed the title kodiPackages.orftvthek: 0.12.12 -> 1.0.2-1 kodiPackages.orftvthek: 0.12.12 -> 1.0.2+matrix.1 Jun 18, 2024
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/s0faking/plugin.video.orftvthek/releases.

meta.description for kodiPackages.orftvthek is: Addon that gives you access to the ORF TVthek Video Platform

meta.homepage for kodiPackages.orftvthek is: https://github.com/s0faking/plugin.video.orftvthek

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.0.2+matrix.1 in filename of file in /nix/store/x0v9qw95gckz5iz27x3g3v6shc6s3a3x-kodi-orftvthek-1.0.2+matrix.1

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

kodiPackages.orftvthek
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/x0v9qw95gckz5iz27x3g3v6shc6s3a3x-kodi-orftvthek-1.0.2+matrix.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A kodiPackages.orftvthek https://github.com/r-ryantm/nixpkgs/archive/4ab9cc62bbf193a19d5ad52d5f14b2d0b0e8674e.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/4ab9cc62bbf193a19d5ad52d5f14b2d0b0e8674e#kodiPackages.orftvthek

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/x0v9qw95gckz5iz27x3g3v6shc6s3a3x-kodi-orftvthek-1.0.2+matrix.1
ls -la /nix/store/x0v9qw95gckz5iz27x3g3v6shc6s3a3x-kodi-orftvthek-1.0.2+matrix.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:
  • kodiPackages.orftvthek

Maintainer pings

cc @aanderse @cpages @dschrempf @edwtjo @nvmd @minijackson @peterhoeg @sephalon for testing.

@aanderse
Copy link
Member

hmmm... so how does the netflix addon for kodi work in nixpkgs? i believe this requires widevine as well... provided by inputstream-adaptive, right? what is the difference between this addon and netflix?

@dschrempf
Copy link
Contributor

OK, thanks for your suggestions and sorry letting you wait @aanderse and @nvmd. I managed to get the addon working, but:

  • inputstream-adaptive is not enough, we really do need the widevine-cdm links @nvmd has mentioned. It is interesting that Netflix works with inputstream-adaptive only which does not provide the DRM stuff (according to the GitHub readme).
  • I have not added the links to the addon derivation yet but instead created them in my home configuration. Could you help me a bit in how to achieve adding the links from the Kodi addon derivation? How can I add a link to the .kodi/cdm directory from within buildKodiAddon? Is this even possible?

Thanks for your help!

@aanderse
Copy link
Member

aanderse commented Jul 2, 2024

i seen to recall using the netflix addon years ago and i had a pop-up asking me to install widevine and everything worked fine.

  • why does this work with netflix but not here?
  • does this addon work if installed through the kodi package manager, and if so, why?
  • what are we missing? let's not hunt for workarounds but instead figure out what we're missing and hopefully it makes sense... and if not, discuss with relevant upstream(s)

@dschrempf
Copy link
Contributor

I see. I think I did not even click the "install widevine" stuff, but assumed it has to be done using Nix, and I managed doing so using links in my personal configuration. I can test if automatic install via Kodi is working, if this is preferred over adding those files using buildKodiAddon. Please let me know!

@aanderse
Copy link
Member

aanderse commented Jul 7, 2024

but assumed it has to be done using Nix

i assumed the exact opposite... your assumption leads to better results but takes more work

how would it work to automate this? the links can exist in nix store?

maybe we merge this the way it is but continue this conversation in another PR?

what do you think?

@dschrempf
Copy link
Contributor

Sorry for the delay! I created a new PR superseding this one: #325934.

@dschrempf dschrempf closed this Jul 9, 2024
@r-ryantm r-ryantm deleted the auto-update/kodiPackages.orftvthek branch July 10, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants