obs-studio: override libcef with obs build #317589
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
wegank
added
the
2.status: merge conflict
flexiondotorg
suggested changes
Jul 5, 2024
| license = with licenses; [ gpl2Plus ] ++ optional withFdk fraunhofer-fdk; | ||
| platforms = [ "x86_64-linux" "i686-linux" "aarch64-linux" ]; | ||
| platforms = [ |
There was a problem hiding this comment.
The architecture should be changed to only list x86_64-linux because the binary build of CEF provided by upstream is x86_64 only.
There was a problem hiding this comment.
Marking this a draft for now. I was searching for binaries for other architectures but wasn't successful. It would be best if our version of CEF would be supported but I'm not sure what's the problem. Using the binary provided by OBS does fix it though.
flexiondotorg
added a commit
to wimpysworld/nix-config
that referenced
this pull request
Jul 5, 2024
flexiondotorg
added a commit
to wimpysworld/nix-config
that referenced
this pull request
Jul 5, 2024
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes Browser sources and docks in obs-studio.
Fixes #335155
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.