needle: init at 0.24.0 #317561
Merged
needle: init at 0.24.0 #317561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteo-pacini
force-pushed
the
needle
branch
2 times, most recently
from
15d7cb9 to
12dab21
Compare
ofborg
bot
added
8.has: package (new)
jtbx
reviewed
Jun 6, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1714 |
SuperSandro2000
approved these changes
Jun 6, 2024
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added new package: needle.
Needle is a Swift dependency injection framework developed by Uber.
This only covers the code generator - the actual framework (
NeedleFramework) is usually fetched from Xcode Projects / Swift.package files outside of nixpkgs.Given the nature of the tool, I've chosen to mark it as darwin only - it could run on Linux, but the chances of this being used there are pretty slim to be honest.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.