Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-editor: init at 25.3.0 #317557

Merged
merged 1 commit into from
Dec 5, 2024
Merged

auto-editor: init at 25.3.0 #317557

merged 1 commit into from
Dec 5, 2024

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Jun 5, 2024

Description of changes

Closes #317015

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@TomaSajt TomaSajt force-pushed the auto-editor branch 2 times, most recently from 4ba7559 to 576b680 Compare June 27, 2024 14:18
pkgs/by-name/au/auto-editor/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/auto-editor/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/auto-editor/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/auto-editor/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/auto-editor/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I haven't tested it.

postPatch = ''
# pyav is a fork of av, but has since been un-forked
substituteInPlace pyproject.toml \
--replace-fail '"pyav' '"av'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand upstream: WyattBlue/auto-editor#485

@TomaSajt TomaSajt force-pushed the auto-editor branch 2 times, most recently from fe3fc84 to 7d7b8b0 Compare October 28, 2024 18:31
@TomaSajt TomaSajt changed the title auto-editor: init at 24w19a auto-editor: init at 25.3.0 Oct 28, 2024
@Aleksanaa Aleksanaa merged commit 0196889 into NixOS:master Dec 5, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: auto-editor
5 participants