Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etebase-server: 0.11.0 -> 0.13.1 #316984

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jun 3, 2024

Description of changes

Removes the dependency on Django 3, noted in #262907. The upstream has a slight issue in their package specifier for Django, so I've patched this and will be submitting a fix upstream. There are no breaking changes, so I haven't updated the release notes.

Edit: The above is obsolete as my patch has been merged into an upstream patch release and I've updated this package to match that version. No further changes are included.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@phaer phaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

pkgs/servers/etebase/default.nix Outdated Show resolved Hide resolved
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jun 4, 2024
Removes the dependency on Django 3, fixing NixOS#262907.
@pyrox0 pyrox0 force-pushed the etebase-server-0.13.0 branch from 749faf7 to 3d3f029 Compare June 4, 2024 20:41
@pyrox0 pyrox0 changed the title etebase-server: 0.11.0 -> 0.13.0 etebase-server: 0.11.0 -> 0.13.1 Jun 4, 2024
@pyrox0 pyrox0 mentioned this pull request Jun 4, 2024
6 tasks
@felschr felschr added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jun 4, 2024
@ofborg ofborg bot requested review from phaer and felschr June 4, 2024 22:46
@pbsbot
Copy link

pbsbot commented Jun 8, 2024

Result of nixpkgs-review pr 316984 run on x86_64-linux 1

2 packages built:
  • etebase-server (python311Packages.etebase-server)
  • etebase-server.dist (python311Packages.etebase-server.dist)

@pbsds
Copy link
Member

pbsds commented Jun 8, 2024

@ofborg build etebase-server

@pbsds pbsds merged commit 2f8d7ea into NixOS:master Jun 8, 2024
32 of 33 checks passed
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Successfully created backport PR for release-24.05:

@pyrox0 pyrox0 deleted the etebase-server-0.13.0 branch August 4, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants