syslinux: fix submodule clone

[SuperSandro2000]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[raboof]

Tested that it works in a nix-shell (with unpackPhase and patchPhase). Not sure I understand the problem, but being able to manipulate gnu-efi-src might be nice anyway, so LGTM.

[raboof]

I'm not sure the g is the problem here: the error message in the current behavior has fatal: Fetched in submodule path 'gnu-efi', but it did not contain d34132e62f666904158c7ec2f1eef5a9d5281c36. Direct fetching of that commit failed., so it seems to get the git hash just fine.

[SuperSandro2000]

Then my best next guess is, that sourceforge is weird. I didn't want to click through many pages to find the old release.

[samueldr]

Is there a linked issue? What problem does that solve?

I don't see a rationale anywhere about this, or a concise way to reproduce an issue.

[samueldr]

Suggested change

	# see 363d61c4f112b972649b19d67e96b9321f738f00 in syslinux
	# see 363d61c4f112b972649b19d67e96b9321f738f00 in syslinux
	# https://repo.or.cz/syslinux.git/commitdiff/363d61c4f112b972649b19d67e96b9321f738f00

[samueldr]

I took some time into actually re-familiarizing myself with the derivation, then fixed the build so we use gnu-efi from Nixpkgs to build the EFI outputs. See #317030.