python311Packages.connectorx: init at 0.3.3 #312884
Open
+74
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
coastalwhite
force-pushed
the
py-connectorx-deltalake
branch
from
3726a82 to
b126aa2
Compare
ofborg
bot
added
8.has: package (new)
pluiedev
suggested changes
May 21, 2024
coastalwhite
changed the title
coastalwhite
force-pushed
the
py-connectorx-deltalake
branch
from
b126aa2 to
904b723
Compare
pluiedev
suggested changes
May 21, 2024
coastalwhite
force-pushed
the
py-connectorx-deltalake
branch
from
904b723 to
d45ac5b
Compare
pluiedev
approved these changes
May 22, 2024
natsukium
reviewed
May 22, 2024
| ]; | ||
|
|
||
| pythonImportsCheck = [ "connectorx" ]; | ||
|
|
There was a problem hiding this comment.
Could you please add pytestCheckHook to nativeCheckInputs?
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#using-pytestcheckhook-using-pytestcheckhook
natsukium
requested changes
May 22, 2024
wegank
added
the
12.approvals: 1
coastalwhite
changed the title
|
Note that deltalake already has a PR #320485. |
wegank
added
the
2.status: merge conflict
coastalwhite
changed the title
coastalwhite
force-pushed
the
py-connectorx-deltalake
branch
from
d45ac5b to
1184aab
Compare
github-actions
bot
added
6.topic: nixos
coastalwhite
force-pushed
the
py-connectorx-deltalake
branch
2 times, most recently
from
dd76ff6 to
8e6dfa2
Compare
github-actions
bot
removed
6.topic: nixos
github-actions
bot
removed
the
6.topic: llvm/clang
coastalwhite
force-pushed
the
py-connectorx-deltalake
branch
from
8e6dfa2 to
4d03c1a
Compare
ofborg
bot
removed
the
2.status: merge conflict
natsukium
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Could you format it with nixfmt-rfc-style and look into the build error?
error: failed to load manifest for dependency `connectorx`
Caused by:
failed to parse manifest at `/build/source/connectorx/Cargo.toml`
Caused by:
dependency (serde) specified without providing a local path, Git repository, version, or workspace dependency to use
- move maturingBuildHook to build-system - use pkgs.krb5
pluiedev
suggested changes
Dec 24, 2024
| @@ -2065,6 +2065,10 @@ self: super: with self; { | |||
|
|
|||
| connection-pool = callPackage ../development/python-modules/connection-pool { }; | |||
|
|
|||
| connectorx = callPackage ../development/python-modules/connectorx { | |||
| krb5-c = pkgs.krb5; | |||
There was a problem hiding this comment.
Is this necessary? (Why not just use krb5 directly?)
There was a problem hiding this comment.
This is because it will otherwise try to use python3Packages.krb5. This is following the comment from above #312884 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds the connectorx python package. These are used by several of the data science and dataframe libraries in the python ecosystem. Specifically, these are packaged now with the hope of better packaging of the polars in the future.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.