Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/hysteria: init #307601

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

nixos/hysteria: init #307601

wants to merge 2 commits into from

Conversation

Guanran928
Copy link
Contributor

@Guanran928 Guanran928 commented Apr 29, 2024 •
edited
Loading

Description of changes

cfg.mode = "client"; is untested, I use another program for client.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 29, 2024
@Guanran928 Guanran928 requested a review from oluceps April 29, 2024 02:04
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 29, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3851

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 22, 2024
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jun 1, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Jun 3, 2024
chayleaf
chayleaf reviewed Jul 4, 2024
View reviewed changes
nixos/modules/services/networking/hysteria.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/hysteria.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/hysteria.nix Outdated Show resolved Hide resolved
@Guanran928 Guanran928 force-pushed the hysteria branch 3 times, most recently from 016589d to d870f65 Compare July 4, 2024 10:22
@Guanran928
Copy link
Contributor Author

See #324955

@Guanran928 Guanran928 marked this pull request as draft July 6, 2024 08:07
@Guanran928 Guanran928 marked this pull request as ready for review July 9, 2024 12:58
@Guanran928 Guanran928 requested a review from linsui July 9, 2024 12:58
@Guanran928 Guanran928 force-pushed the hysteria branch 2 times, most recently from 339bbba to 410fd7d Compare July 9, 2024 19:33
@Guanran928 Guanran928 force-pushed the hysteria branch 2 times, most recently from c4ea37e to 02de8ae Compare July 9, 2024 19:39
ocfox
ocfox suggested changes Jul 9, 2024
View reviewed changes
nixos/modules/services/networking/hysteria.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/hysteria.nix Outdated Show resolved Hide resolved
@Guanran928 Guanran928 force-pushed the hysteria branch 5 times, most recently from 68815fe to 3474b23 Compare July 9, 2024 21:23
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@Guanran928 Guanran928 removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayleaf chayleaf chayleaf left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@ocfox ocfox ocfox requested changes

@linsui linsui linsui approved these changes

@oluceps oluceps Awaiting requested review from oluceps

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Guanran928 @nixos-discourse @SuperSandro2000 @chayleaf @linsui @ocfox @wegank @h7x4