private-gpt: init at 0.5.0 #299738
Closed
private-gpt: init at 0.5.0 #299738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
force-pushed
the
private-gpt/init
branch
2 times, most recently
from
044f26c to
d048315
Compare
ofborg
bot
added
8.has: package (new)
drupol
force-pushed
the
private-gpt/init
branch
2 times, most recently
from
65c283d to
91a0492
Compare
|
#299768 will provide some of the
|
drupol
force-pushed
the
private-gpt/init
branch
from
91a0492 to
8951c76
Compare
drupol
force-pushed
the
private-gpt/init
branch
from
8951c76 to
d68e45a
Compare
Comment on lines
8
to
11
| postInstall = '' | ||
| makeWrapper ${python3Packages.python.interpreter} $out/bin/private-gpt \ | ||
| --prefix PYTHONPATH : "$PYTHONPATH" \ | ||
| --add-flags "-m private_gpt" |
There was a problem hiding this comment.
Do you think upstream would accept a PR wrapping their uvicorn.run(...) in:
def main():
...
if __name__ == "__main__":
main()
so that you could instead specify ...:main in pyproject.toml's scripts?
It's preferable to avoid setting PYTHONPATH when possible
There was a problem hiding this comment.
I don't use python usually and I'm not acquainted with its ecosystem. So the least help is very welcome .
ofborg
bot
added
the
11.by: package-maintainer
drupol
force-pushed
the
private-gpt/init
branch
from
d68e45a to
770e778
Compare
github-actions
bot
added
6.topic: nixos
drupol
force-pushed
the
private-gpt/init
branch
3 times, most recently
from
cd9817b to
9e50be9
Compare
drupol
force-pushed
the
private-gpt/init
branch
from
9e50be9 to
0c97ced
Compare
|
The work continue on this PR : #305586 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix: #232681
Status: working
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.