Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rling: init at unstable-2023-09-02 #280787

Closed
wants to merge 0 commits into from
Closed

rling: init at unstable-2023-09-02 #280787

wants to merge 0 commits into from

Conversation

octodi
Copy link
Contributor

@octodi octodi commented Jan 13, 2024

Description of changes

Added rling a faster multi-threaded, feature rich alternative to rli found in hashcat utilities.

https://github.com/Cynosureprime/rling

Related to #81418

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 13, 2024
tomodachi94
tomodachi94 requested changes Oct 26, 2024
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and apologies for the delay! I've left a few comments about potential improvements.

pkgs/by-name/rl/rling/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/rl/rling/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/rl/rling/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/rl/rling/package.nix Outdated Show resolved Hide resolved
@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor labels Oct 26, 2024
@octodi octodi removed 6.topic: erlang 6.topic: ocaml 10.rebuild-linux: 1-10 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 11.by: package-maintainer This PR was created by the maintainer of the package it changes 6.topic: xfce The Xfce Desktop Environment 6.topic: nodejs 6.topic: pantheon The Pantheon desktop environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: testing Tooling for automated testing of packages and modules 6.topic: cinnamon Desktop environment 6.topic: module system About "NixOS" module system internals 10.rebuild-linux: 1 6.topic: systemd 6.topic: agda "A dependently typed programming language / interactive theorem prover" 6.topic: nim Nim programing language 6.topic: LXQt The Lightweight Qt Desktop Environment 6.topic: Lumina DE The Lumina Desktop Environment 6.topic: Enlightenment DE The Enlightenment Desktop Environment 6.topic: mate The MATE Desktop Environment 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 6.topic: zig 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: php 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: dotnet Language: .NET 6.topic: xen-project The Xen Project hypervisor labels Oct 26, 2024
@tomodachi94 tomodachi94 added the 2.status: invalid "This doesn't seem right": Issues or PRs that are unintelligible label Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomodachi94 tomodachi94 tomodachi94 requested changes

Assignees
No one assigned
Labels
2.status: invalid "This doesn't seem right": Issues or PRs that are unintelligible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@octodi @tomodachi94