llvm/16: Fix compiler-rt missing sanitizers when using useLLVM

[s1341]

Attempts to address #97688 by refactoring the llvm/16 toolchain build to make more sense.

The build order is now:

1. {compiler-rt-no-libc}
2. {compiler-rt-no-libc, libc}
3. {compiler-rt-no-libc, libc, libc++}
4. {compiler-rt-no-libc, libc, libc++, compiler-rt-libc}

The names of the stages have been updated to reflect this.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[s1341]

Hrm. I don't know why it is infinite-recursioning. I don't have that issue locally. How can I reproduce what ofborg ran?

[Artturin]

Don't reformat the file, it needs to be similar to the other llvm versions for diffing.

It's impossible to tell what changes you've made in it.

[s1341]

Sorry. it was accidental. I will fix it and push, but it'll have to be sunday.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3534

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3648

[SuperSandro2000]

This PR rebuilds a lot of packages which means we must target staging. Please follow the contributing guide to not potentially ping a lot of people.

[SuperSandro2000]

Locking this to avoid more pings because of the bad rebase. Please open a new PR.

[Ericson2314]

#297144 is the successor PR.