Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode, VSCodium 1.78.2 + cleanups #232280

Merged
merged 3 commits into from
May 17, 2023
Merged

VSCode, VSCodium 1.78.2 + cleanups #232280

merged 3 commits into from
May 17, 2023

Conversation

K900
Copy link
Contributor

@K900 K900 commented May 16, 2023

Description of changes

https://github.com/microsoft/vscode/releases

Note 1.78.1 is a security patch.

Closes #232296

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@K900
Copy link
Contributor Author

K900 commented May 16, 2023

Result of nixpkgs-review pr 232280 run on x86_64-linux 1

5 packages built:
  • vscode
  • vscode-fhs
  • vscode-with-extensions
  • vscodium
  • vscodium-fhs

@gilice
Copy link
Member

gilice commented May 16, 2023

Why drop armhf?
If you have an amend to the commit message would be appreciated.
It is unclear from the release notes, but maybe it was discontinued upstream?

@K900
Copy link
Contributor Author

K900 commented May 16, 2023

It was in fact discontinued upstream. VSCodium/vscodium@7afbfe0

@K900 K900 force-pushed the vscode-1.78.2 branch from 09d3aaa to 72ffc99 Compare May 16, 2023 18:33
@gilice
Copy link
Member

gilice commented May 16, 2023

thanks!

@bobby285271
Copy link
Member

bobby285271 commented May 16, 2023

Why drop armhf?

The build fails. I imagine the story is similar to VSCodium/vscodium#1072 that upstream has no time to investigate and can be re-enabled once "someone knows how to fix" 🙃 Personally fine for me not to wait for it

(The wayland aarch64-linux test timeout is an existing one)

@bobby285271 bobby285271 mentioned this pull request May 16, 2023
10 tasks
@K900 K900 merged commit 85b00a0 into NixOS:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants