systemd-lock-handler: init at 2.4.1 #228063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
github-actions
bot
added
6.topic: nixos
MatthewCroughan
force-pushed
the
mc/systemd-lock-handler
branch
from
a007131 to
a4b6d58
Compare
liff
suggested changes
Jul 20, 2023
Comment on lines
+12
to
+17
| package = mkOption { | ||
| default = pkgs.systemd-lock-handler; | ||
| defaultText = literalExpression "pkgs.systemd-lock-handler"; | ||
| type = types.package; | ||
| description = lib.mdDoc "systemd-lock-handler package to use."; | ||
| }; |
There was a problem hiding this comment.
There seems to be a helper, like mkEnableOption, for this:
Suggested change
| package = mkOption { | |
| default = pkgs.systemd-lock-handler; | |
| defaultText = literalExpression "pkgs.systemd-lock-handler"; | |
| type = types.package; | |
| description = lib.mdDoc "systemd-lock-handler package to use."; | |
| }; | |
| package = mkPackageOption pkgs "systemd-lock-handler" { }; |
| type = types.package; | ||
| description = lib.mdDoc "systemd-lock-handler package to use."; | ||
| }; | ||
| config = mkIf cfg.enable { |
There was a problem hiding this comment.
This is nested inside options.services.systemd-lock-handler (hence the build failure), so there should be a }; before this.
| serviceConfig = { | ||
| Documentation = "https://sr.ht/~whynothugo/systemd-lock-handler"; | ||
| Slice = [ "session.slice" ]; | ||
| ExecStart = "${cfg.package}/bin/systemd-lock-handler"; |
There was a problem hiding this comment.
Suggested change
| ExecStart = "${cfg.package}/bin/systemd-lock-handler"; | |
| ExecStart = getExe cfg.package |
|
|
||
| buildGoModule rec { | ||
| pname = "systemd-lock-handler"; | ||
| version = "2.4.1"; |
There was a problem hiding this comment.
Version 2.4.2 has been released.
There was a problem hiding this comment.
Perhaps also add updateScript?
passthru.updateScript = nix-update-script { };
|
Have been looking into using this so would like to see it get in :) |
12 tasks
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
|
Superseded by #259196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds systemd-lock-handler to Nixpkgs
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)