Introduce bogus ratchet check ensuring that no new Nix string files are introduced #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
force-pushed
the
file-ratchet-check
branch
from
22603ba to
00815fa
Compare
infinisil
force-pushed
the
no-string-files
branch
from
9268d60 to
003a4ad
Compare
A future commit introduces checks on all Nix files, but this is problematic if the base Nixpkgs version is part of the main Nixpkgs version
For now without any checks, but this makes introducing ones fairly easy
infinisil
force-pushed
the
file-ratchet-check
branch
from
00815fa to
30686e7
Compare
infinisil
force-pushed
the
no-string-files
branch
from
003a4ad to
53c3767
Compare
infinisil
force-pushed
the
file-ratchet-check
branch
from
30686e7 to
6b52b12
Compare
philiptaron
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Thanks, this is really helpful for understanding #144. Somehow did not see it until just now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #144 as an example of how something like this can be done for #142
This work is funded by Tweag and Antithesis ✨