Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XDG Desktop Portal to open URIs and files #2461

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Jan 9, 2025

Resolves #1676 and related to #2436.

@erri120 erri120 requested a review from a team January 9, 2025 13:48
@erri120 erri120 self-assigned this Jan 9, 2025
Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Only reviewed App code, not your NuGet library. (ps. BATMAN)

When I rebooted and tested on Windows, /select was broken, but it seems you already caught on to that.

As for #1676, I think it's probably ok to close for now. For Flatpak we'll need host filesystem access most likely to scan for games and write to game folders; but outside of that, we've got it mostly covered.

Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test on Linux, but looks good

@erri120 erri120 merged commit e39ee0d into Nexus-Mods:main Jan 9, 2025
12 checks passed
@erri120 erri120 deleted the feat/1676-portals branch January 9, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Consider using XDG Desktop Portal for Linux OS Interop
3 participants