Merge pull request #114 from NeoA11y/bugfix/ISSUE#109-read-empty-edit…

…-text Read empty edit text
NeoA11y · Nov 27, 2023 · df538c5 · df538c5
2 parents 885e92f + 14fe2a6
commit df538c5
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 2 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -0,0 +1,23 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: bug
+assignees: ''
+
+---
+
+## Describe the bug:
+
+## To Reproduce:
+
+## Expected behavior
+
+## Screenshots:
+
+## Stack trace (to dev):
+
+## More infos:
+App version:
+Android version:
+Device:
diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md
@@ -0,0 +1,10 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: feature
+assignees: ''
+
+---
+
+
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -0,0 +1,5 @@
+### Description
+
+### Improvements
+
+### Fixed issues
diff --git a/app/src/main/java/com/neo/speaktouch/utils/NodeValidator.kt b/app/src/main/java/com/neo/speaktouch/utils/NodeValidator.kt
@@ -92,7 +92,7 @@ object NodeValidator {
     /**
      * @return true if is mandatory read [node]'s children
      */
-    fun mustReadChildren(node: AccessibilityNodeInfoCompat) : Boolean {
+    fun mustReadChildren(node: AccessibilityNodeInfoCompat): Boolean {
 
         if (mustReadContent(node)) return false
 
@@ -104,7 +104,11 @@ object NodeValidator {
      */
     fun hasContentToRead(node: AccessibilityNodeInfoCompat): Boolean {
 
-        return hasTextToRead(node) || node.isCheckable
+        if (node.isCheckable) return true
+
+        if (node.isEditable) return true // TODO: Consider removing after issue #88
+
+        return hasTextToRead(node)
     }
 
     /**