Refactor UpgradeEntityRequests and DestructEntityRequests #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlayerAction_Build.Do(Destruct/Upgrade)Object() was being run multiple times resulting in players receiving multiple of the same item so we should ensure this only runs once
|
Also just to add, I wasn't able to reproduce #378 locally with this PR, but it's been notoriously hard to reproduce alone while trying to control 2 clients so it could still be an issue |
|
I'm gonna merge this because no one has reported any errors so far and if anything this definitely fixes an item dupe bug which should be included in the next release EDIT: I think someone other than me has to review it before it can be merged, which makes sense 😅 |
hubastard
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlayerAction_Build.Do(Destruct/Upgrade)Object() was being run multiple times resulting in players receiving multiple of the same item so we should ensure this only runs once
This may bring back #378, needs further testing, but fixes the other problem mentioned on that issue.