Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host can generate NRE when loading a planet that a client is building on #378

Open
PhantomGamers opened this issue Jul 19, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@PhantomGamers
Copy link
Collaborator

as in, when the host is arriving on the planet

image

This might already be fixed with the currently method we are using in master, but the problem with the method being used now is that clients can receive multiple items back when they are dismantling items due to PlayerAction_Build.DoDismantleObject() potentially running multiple times

@PhantomGamers
Copy link
Collaborator Author

PhantomGamers commented Jul 22, 2021

With #377 this can be triggered from the LoadPlanetData function calling CreateRenderingBatches() hmm
image

EDIT: This was actually a different issue, fixed in that PR.

@PhantomGamers PhantomGamers added the bug Something isn't working label Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant