T#2426/expiration history #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-may
requested changes
Oct 10, 2023
There was a problem hiding this comment.
• Idea: rename 'EXPIRATION HISTORY' page title to 'SKILL EXPIRATION HISTORY'
• not really part of the ticket but let's move Settings to the bottom of the navigation
• Expiration history icon is green - seems like maybe too similar to Admin Activity color - maybe find another color?
• please add cypress accessibility tests
...ice/src/test/java/skills/intTests/skillExpiration/PostAchievementSkillExpirationSpecs.groovy
Show resolved
Hide resolved
service/src/main/java/skills/services/admin/UserAchievementExpirationService.groovy
Outdated
Show resolved
Hide resolved
dwalizer
force-pushed
the
t#2426/expiration-history
branch
from
ef62942 to
b9be8f6
Compare
sudo-may
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.