Skip to content

Commit

Permalink
#1810: lighthouse best-practices score does not match score produced …
Browse files Browse the repository at this point in the history
…by the browser plugin
  • Loading branch information
EVOFORGE\dimay committed Nov 28, 2022
1 parent f8b34d5 commit b8d67e3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion e2e-tests/cypress/e2e/accessibility_specs.js
Original file line number Diff line number Diff line change
Expand Up @@ -669,12 +669,16 @@ describe('Accessibility Tests', () => {
});

it('settings - system', () => {
cy.intercept('GET', '/root/getSystemSettings')
.as('getSettings');
cy.logout();
cy.login('[email protected]', 'password');
cy.visit('/settings/system');
cy.injectAxe();
cy.wait('@getSettings')
cy.contains('Token Expiration');
cy.get('[data-cy="resetTokenExpiration"]').should('have.value', '2H')
cy.get('[data-cy="saveSystemSettings"]')
cy.injectAxe();
cy.customLighthouse();
cy.customA11y();
});
Expand Down
2 changes: 1 addition & 1 deletion e2e-tests/cypress/support/commands.js
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ Cypress.Commands.add('customLighthouse', () => {
cy.lighthouse({
"performance": 0,
"accessibility": 90,
"best-practices": 85,
"best-practices": 80,
"seo": 0,
"pwa": 0
}, {}, lighthouseOptions);
Expand Down

0 comments on commit b8d67e3

Please sign in to comment.