Skip to content

Commit

Permalink
Merge pull request #1577 from NationalSecurityAgency/t#1576/cypress_u…
Browse files Browse the repository at this point in the history
…pgrade

T#1576/cypress upgrade
  • Loading branch information
dwalizer authored Aug 18, 2022
2 parents 4349ee9 + b6d1c8c commit 830c518
Show file tree
Hide file tree
Showing 451 changed files with 40,588 additions and 26,754 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,13 @@ jobs:
- name: Prep Services for Cypress tests
run: |
cd e2e-tests
ls
npm install
npm run cyServices:start
cd ..
- name: Run Cypress tests
uses: cypress-io/github-action@v2
uses: cypress-io/github-action@v4
with:
working-directory: e2e-tests
record: true
Expand Down
13 changes: 10 additions & 3 deletions dashboard/src/components/myProgress/MyProjectSkillsPage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ limitations under the License.
*/
<template>
<div>
<skills-display
<div v-if="isLoadingSettings" class="d-flex justify-content-center mt-1">
<b-spinner variant="primary" type="grow" label="Spinning"></b-spinner>
</div>
<skills-display v-if="!isLoadingSettings"
:options="options"
:version="skillsVersion"
:theme="themeObj"
Expand All @@ -27,8 +30,8 @@ limitations under the License.
<script>
import { SkillsDisplay } from '@skilltree/skills-client-vue';
import MyProgressService from '@/components/myProgress/MyProgressService';
import SkillsDisplayOptionsMixin from './SkillsDisplayOptionsMixin';
import SettingsService from '../settings/SettingsService';
import SkillsDisplayOptionsMixin from '@/components/myProgress/SkillsDisplayOptionsMixin';
import SettingsService from '@/components/settings/SettingsService';
export default {
name: 'MyProjectSkillsPage',
Expand All @@ -38,6 +41,7 @@ limitations under the License.
},
data() {
return {
isLoadingSettings: true,
projectId: this.$route.params.projectId,
projectDisplayName: 'PROJECT',
skillsVersion: 2147483647, // max int
Expand Down Expand Up @@ -100,6 +104,7 @@ limitations under the License.
};
},
mounted() {
this.isLoadingSettings = true;
SettingsService.getClientDisplayConfig(this.projectId).then((response) => {
this.projectDisplayName = response.projectDisplayName?.toUpperCase();
if (!this.$route.params.name) {
Expand All @@ -111,6 +116,8 @@ limitations under the License.
} else {
this.$set(this.theme, 'landingPageTitle', `${this.projectDisplayName}: ${this.$route.params.name}`);
}
}).finally(() => {
this.isLoadingSettings = false;
});
},
computed: {
Expand Down
29 changes: 29 additions & 0 deletions e2e-tests/cypress.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
const { defineConfig } = require('cypress')

module.exports = defineConfig({
projectId: '7kivjf',
requestTimeout: 10000,
defaultCommandTimeout: 10000,
numTestsKeptInMemory: 50,
chromeWebSecurity: false,
retries: {
runMode: 2,
openMode: 0,
},
lighthouse: {
performance: 85,
accessibility: 90,
'best-practices': 85,
seo: 50,
pwa: 50,
},
e2e: {
// We've imported your old cypress plugins here.
// You may want to clean this up later by importing these.
setupNodeEvents(on, config) {
return require('./cypress/plugins/index.js')(on, config)
},
baseUrl: 'http://localhost:8080',
specPattern: 'cypress/e2e/**/*.{js,jsx,ts,tsx}',
},
})
19 changes: 0 additions & 19 deletions e2e-tests/cypress.json

This file was deleted.

Loading

0 comments on commit 830c518

Please sign in to comment.