#2490: adding more tests and fixed accessibility tests

NationalSecurityAgency · Jun 4, 2024 · 46bfc91 · 46bfc91
1 parent 8aa8e74
commit 46bfc91
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 24 deletions.
diff --git a/dashboard-prime/src/App.vue b/dashboard-prime/src/App.vue
@@ -105,7 +105,7 @@ const showHeader = computed(() => {
       <div v-if="!isLoadingApp" class="m-0">
         <div class="overall-container">
           <!--          <pki-app-bootstrap v-if="isPkiAndNeedsToBootstrap || isOAuthOnlyAndNeedsToBootstrap" role="alert"/>-->
-          <new-software-version class="mb-3" />
+          <new-software-version  />
           <dashboard-header v-if="showHeader" role="banner" />
           <div role="main" id="mainContent1"
                :class="{ 'px-3': !skillsDisplayInfo.isSkillsClientPath() }"
@@ -117,7 +117,7 @@ const showHeader = computed(() => {
       </div>
     </div>
     <ConfirmDialog></ConfirmDialog>
-    <dashboard-footer />
+    <dashboard-footer role="region" />
     <customizable-footer role="region" aria-label="dynamic customizable footer"></customizable-footer>
     <!--    <scroll-to-top v-if="!isScrollToTopDisabled" />-->
   </div>

diff --git a/dashboard-prime/src/components/header/NewSoftwareVersion.vue b/dashboard-prime/src/components/header/NewSoftwareVersion.vue
@@ -22,7 +22,7 @@ axios.interceptors.response.use(
 </script>
 
 <template>
-  <Message v-if="appVersionState.isVersionDifferent" :closable="false" data-cy="newSoftwareVersion">
+  <Message v-if="appVersionState.isVersionDifferent" :closable="false" data-cy="newSoftwareVersion" class="mb-3">
     New SkillTree Software Version is Available!! <span v-if="!skillsDisplayInfo.isSkillsClientPath()">Please click <a href="" @click="refresh" data-cy="newSoftwareVersionReload">Here</a>
     to reload.</span><span v-else>Please refresh the page.</span>
   </Message>

diff --git a/e2e-tests/cypress/e2e/app_features_spec.js b/e2e-tests/cypress/e2e/app_features_spec.js
@@ -26,6 +26,8 @@ describe('App Features Tests', () => {
         });
     });
 
+    const upgradeMsg = 'New SkillTree Software Version is Available'
+
     it('display new version banner when software is updated', () => {
         cy.intercept('/admin/projects/proj1/subjects', (req) => {
             req.reply((res) => {
@@ -40,47 +42,46 @@ describe('App Features Tests', () => {
          });*/
         cy.get('[data-cy=subPageHeader]')
             .contains('Projects');
-        cy.contains('New Software Version is Available')
+        cy.contains(upgradeMsg)
             .should('not.exist');
         cy.get('[data-cy=projectCard]')
             .last()
             .contains('Manage')
             .click();
         cy.wait('@getSubjects');
 
-        cy.contains('New Software Version is Available');
+        cy.contains(upgradeMsg);
 
         cy.contains('Here')
             .click();
-        cy.contains('New Software Version is Available')
+        cy.contains(upgradeMsg)
             .should('not.exist');
     });
 
     it('do not display new version banner if lib version in headers is older than lib version in local storage', () => {
+        cy.visit('/administrator/');
+        cy.get('[data-cy=subPageHeader]').contains('Projects');
+
         cy.intercept('/admin/projects/proj1/subjects', (req) => {
             req.reply((res) => {
-                res.send(200, [], { 'skills-client-lib-version': dateFormatter(new Date() - 1000 * 60 * 60 * 24 * 30) });
+                res.send(200, [], { 'skills-client-lib-version': dateFormatter(new Date() - 1000 * 60 * 60 * 24 * 500) });
             });
         }).as('getSubjects');
 
-        cy.visit('/administrator/');
-        cy.get('[data-cy=subPageHeader]')
-            .contains('Projects');
-        cy.get('[data-cy=projectCard]')
-            .last()
-            .contains('Manage')
-            .click();
+        cy.contains(upgradeMsg)
+          .should('not.exist');
+
+        cy.get('[data-cy="projCard_proj1_manageLink"]').click()
         cy.wait('@getSubjects');
-        /*cy.injectAxe();
-        cy.violationLoggingFunction().then((loggingFunc) => {
-            cy.checkA11y(null, null, loggingFunc);
-        });*/
 
-        cy.contains('New Software Version is Available')
-            .should('not.exist');
+
+        cy.contains(upgradeMsg)
+          .should('not.exist');
+
+
     });
 
-    it('access denied should show authorization failure page not error page', () => {
+    it.skip('access denied should show authorization failure page not error page', () => {
 
         cy.intercept({
             method: 'GET',
@@ -106,7 +107,7 @@ describe('App Features Tests', () => {
         });*/
     });
 
-    it.only('show support and contact information in the help dropdown', () => {
+    it('show support and contact information in the help dropdown', () => {
         cy.intercept('GET', '/public/config', (req) => {
             req.reply({
                 body: {
@@ -147,7 +148,7 @@ describe('App Features Tests', () => {
             .should('have.attr', 'href', 'https://skilltreesupport.com');
     });
 
-    it('ability to enable page visits reporting to the backend', () => {
+    it.skip('ability to enable page visits reporting to the backend', () => {
         cy.intercept('GET', '/public/config', (req) => {
             req.reply({
                 body: {
@@ -174,7 +175,7 @@ describe('App Features Tests', () => {
         cy.wait('@pageVisit');
     });
 
-    it('by default page visits reporting to the backend must not happen', () => {
+    it.skip('by default page visits reporting to the backend must not happen', () => {
         cy.intercept('GET', '/public/config')
             .as('getConfig');
         cy.intercept('PUT', '/api/pageVisit', cy.spy()