#2490 - always validate on load when editing

NationalSecurityAgency · Jul 1, 2024 · 0630714 · 0630714
1 parent 6b19469
commit 0630714
Showing 1 changed file with 20 additions and 20 deletions.
diff --git a/dashboard-prime/src/components/utils/inputForm/SkillsInputFormDialog.vue b/dashboard-prime/src/components/utils/inputForm/SkillsInputFormDialog.vue
@@ -130,6 +130,25 @@ watch(() => errors.value, (newValue) => {
   emit('errors', newValue)
 })
 
+const validateIfEditOrNotEmpty = () => {
+  const skipAttrs = toRaw(values)['skipTheseAttrsWhenValidatingOnInit'] || []
+  if (!props.initialValues) {
+    console.error(`Initial values for SkillsInputFormDialog id=[${props.id}] not provided.`)
+  }
+  if (props.isEdit) {
+    validate()
+  } else {
+    const foundNonEmpty = Object.entries(values)
+        .find(([key, value]) =>
+            key !== 'skipTheseAttrsWhenValidatingOnInit'
+            && !skipAttrs.includes(key)
+            && value && !deepEqual((props.initialValues[key]), (value)))
+    if (foundNonEmpty) {
+      validate()
+    }
+  }
+}
+
 if (props.asyncLoadDataFunction) {
   isLoadingAsyncData.value = true
   props.asyncLoadDataFunction().then((res) => {
@@ -159,25 +178,6 @@ if (props.asyncLoadDataFunction) {
   }
 }
 
-const validateIfEditOrNotEmpty = () => {
-  const skipAttrs = toRaw(values)['skipTheseAttrsWhenValidatingOnInit'] || []
-  if (!props.initialValues) {
-    console.error(`Initial values for SkillsInputFormDialog id=[${props.id}] not provided.`)
-  }
-  if (props.isEdit) {
-    validate()
-  } else {
-    const foundNonEmpty = Object.entries(values)
-        .find(([key, value]) =>
-            key !== 'skipTheseAttrsWhenValidatingOnInit'
-            && !skipAttrs.includes(key)
-            && value && !deepEqual((props.initialValues[key]), (value)))
-    if (foundNonEmpty) {
-      validate()
-    }
-  }
-}
-
 </script>
 
 <template>
@@ -216,7 +216,7 @@ const validateIfEditOrNotEmpty = () => {
   z-index: 999;
   height: 2em;
   width: 2em;
-  overflow: show;
+  overflow: visible;
   margin: auto;
   top: 0;
   left: 0;