Removing unused reduced response from various Attribute methods #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mineralntl
force-pushed
the
task/removeUnusedReducedResponse
branch
from
9c5d985 to
3f89c8a
Compare
apmoriarty
previously approved these changes
Nov 18, 2024
mineralntl
force-pushed
the
task/removeUnusedReducedResponse
branch
4 times, most recently
from
c118409 to
1848ab8
Compare
mineralntl
force-pushed
the
task/removeUnusedReducedResponse
branch
from
1848ab8 to
89b501a
Compare
mineralntl
force-pushed
the
task/removeUnusedReducedResponse
branch
6 times, most recently
from
70dd54b to
4dc12aa
Compare
mineralntl
force-pushed
the
task/removeUnusedReducedResponse
branch
2 times, most recently
from
37a474a to
449c53e
Compare
apmoriarty
approved these changes
Dec 16, 2024
ivakegg
approved these changes
Dec 16, 2024
alerman
approved these changes
Dec 17, 2024
mineralntl
force-pushed
the
task/removeUnusedReducedResponse
branch
from
449c53e to
5c59228
Compare
mineralntl
force-pushed
the
task/removeUnusedReducedResponse
branch
from
5c59228 to
81ec564
Compare
mineralntl
force-pushed
the
task/removeUnusedReducedResponse
branch
from
81ec564 to
b03b798
Compare
mineralntl
force-pushed
the
task/removeUnusedReducedResponse
branch
from
b03b798 to
79c3414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up where #1458 left off due to staleness. This seeks to remove unused reducedResponse parameters from some of the Attribute uses across the codebase.