-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only allow host-relative LDConfig paths #690
Conversation
24ede29
to
74d8d64
Compare
74d8d64
to
994c973
Compare
994c973
to
08fb0bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Let's continue to allow host-relative path to ldconfig even without the override
- Let's then change the override flag to be called
allow-ldconfig-from-container
08fb0bc
to
72a0400
Compare
@elezar besides rebasing, are there any other changes planned for this PR? Question -- is it possible to include a comment in the default NVIDIA Container Toolkit config file that gets installed at |
Signed-off-by: Evan Lezar <[email protected]>
This change removes indirect calls to get the default config from the nvidia-container-runtime-hook. Signed-off-by: Evan Lezar <[email protected]>
72a0400
to
c20d246
Compare
This change only allows host-relative LDConfig paths. An allow-ldconfig-from-container feature flag is added to allow for this the default behaviour to be changed. Signed-off-by: Evan Lezar <[email protected]>
c20d246
to
00f1d5a
Compare
The features are currently update I have looked at what is required to add a comment to the |
This change only allows host-relative LDConfig paths (i.e. the
nvidia-container-cli.ldconfig
setting starts with an@
)An
allow-ldconfig-from-container
feature flag is added to allow for thisthe default behaviour to be changed.
This feature can be toggled by running:
or by including
allow-config-from-container
in theNVIDIA_CONTAINER_TOOLKIT_OPT_IN_FEATURES
envvar.