Skip to content

Commit

Permalink
net_ib: return ncclSuccess if read roceTypePath failed and errno is E…
Browse files Browse the repository at this point in the history
…INVAL. #890
  • Loading branch information
lijunli committed Sep 5, 2024
1 parent 178b6b7 commit dc445aa
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/transport/net_ib.cc
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,10 @@ static ncclResult_t ncclIbRoceGetVersionNum(const char* deviceName, int portNum,
close(fd);

if (ret == -1) {
WARN("NET/IB: read failed: %s, roceTypePath: %s", strerror(errno), roceTypePath);
if (errno == EINVAL) {
return ncclSuccess;
}
return ncclSystemError;
}

Expand Down

1 comment on commit dc445aa

@gcongiu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also initialize gidRoceVerNumCandidate = -1 in ncclUpdateGidIndex

Please sign in to comment.