[FEA] hook-based support for distributed but shared parameter #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaysubr
reviewed
Dec 6, 2023
There was a problem hiding this comment.
This PR looks good to me. Suggested some relatively minor changes.
The only other major comment I have is to also evaluate DDP reduction hooks vs these tensor hooks and whether or not that approach is preferable due to the explicit non-blocking communication routines.
stadlmax
commented
Dec 8, 2023
|
/blossom-ci |
stadlmax
changed the title
akshaysubr
approved these changes
Dec 11, 2023
|
/blossom-ci |
stadlmax
added
4 - In Review
|
/blossom-ci |
|
/blossom-ci |
mnabian
approved these changes
Dec 15, 2023
|
/blossom-ci |
2 similar comments
|
/blossom-ci |
|
/blossom-ci |
|
/blossom-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modulus Pull Request
Description
#235 asks for support for distributed parameters which are shared across the model-parallel group. Initially, there was the idea of using a wrapper idea. The hook-based approach, however, should be less intrusive and more flexible and is introduced in this draft. Shared weights are simply marked or unmarked as needed which registers a gradient hook taking care of the necessary reduction of gradients.
closes #235 , but with a different implementation idea
Checklist
Dependencies