New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross platform and proplib2.0 #6

Open

cheroy-ntia wants to merge 192 commits into master from CrossPlatform-And-PropLib2.0

Collaborator

cheroy-ntia commented Nov 12, 2024

No description provided.

aromanielloNTIA and others added 30 commits

September 27, 2024 16:21


          Initial commit

3c8c6a1


          Add googletest and doxygen-awesome-css submodules

fc52cc4

doxygen-awesome-css is checkout out to v2.3.3 tag


          Add info about merging template changes to downstream

6e77c0b


          Update doxygen-awesome-css to v2.3.4

23b21f8


          Merge pull request #1 from NTIA/doxygen-awesome-css-v2.3.4

b65ec43

Update doxygen-awesome-css to v2.3.4


          Update examples to recommend constexpr instead of macros

a258519


          Merge pull request #2 from NTIA/avoid-macros-as-constants

26fd183

Update examples to recommend constexpr instead of macros


          Merge pull request #3 from NTIA/dev

cd1a20a

Merge recent updates


          Delete CREATING-REPOSITORIES.md

2d8a04d

Moved contents to GitHub wiki


          Add CLI app to cmake configuration

f1f34aa


          Update CLI app readme for templating

674e808


          make GetDatetimeString thread-safe across platforms

bc6c924


          move functions to utils


          Add driver testing configuration

aa4257a


          modernize driver utility functions

48d3c6d

use strings, avoid pointers, fix a typo in Version output


          const correct driver util functions

5b23eb6


          rename Utils to DriverUtils

c333e6e


          Add simple tests for parsing functions

4dae8a6


          Avoid duplicate googletest init

df9f3a1


          enable exports for driver tests

214465d


          remove default from Version definition

fa67822


          Reorganize driver code

909b70f


          Add include directories for driver and driver tests

e7285b1


          parameterize help output stream

2ed99de


          Add CommaSeparatedIterator

ea672a5


          Relocate ctime include

78f0561


          Rename main.cpp to Driver.cpp

e3efa97


          Add input file opening error code

63e3de7


          Better use of cmake variable

19eb5e4


          Reformat cmakelists

53fbd0f

remove unused variable

aromanielloNTIA and others added 13 commits

November 26, 2024 15:19


          fix typo

4ea1395


          Add macOS multi-architecture logic

a621d1e


          Merge branch 'main' into support-macos-multiarch-in-CI

e9af93e


          Add windows x86 runner

1b6d50f


          fix matrix architecture exclude

3c27db4


          try OS type name in action matrix names

6ef1124


          Revert "try OS type name in action matrix names"

193b046

This reverts commit 6ef1124.


          Add compiler flags

39cd0a1

MSVC: always use /Gz
G++ equivalents: none required for Gz


          Fix incorrect field used

bcb09a2


          epsilon > 1

48db825


          add more Equivalence tests

ad22fc8


          Merge branch 'proplib-template-main' into CrossPlatform-And-PropLib2.0

fd371a4

# Conflicts:
#	.zenodo.json
#	CITATION.cff
#	CMakeLists.txt
#	GitHubRepoPublicReleaseApproval.md
#	README.md
#	app/CMakeLists.txt
#	app/include/Driver.h
#	app/src/CMakeLists.txt
#	app/tests/CMakeLists.txt
#	src/CMakeLists.txt
#	src/ReturnCodes.cpp
#	tests/CMakeLists.txt
#	tests/TestUtils.cpp


          update README

349d994

cheroy-ntia requested review from wkozmaNTIA, blainNTIA and aromanielloNTIA

November 29, 2024 21:12

cheroy-ntia marked this pull request as ready for review

November 29, 2024 21:12


          remove not used test data

18d9dfd

aromanielloNTIA requested changes

View reviewed changes

Member

aromanielloNTIA left a comment

Please see my comments in line and make corresponding changes.

include/ITS.Propagation.LFMF/LFMF.h Outdated Show resolved Hide resolved

include/ITS.Propagation.LFMF/LFMF.h Outdated

+              #define R2D                         180.0/PI                ///< Approximate convert ratio from Radians to Degrees
+              #define ETA                         119.9169832*PI          ///< Intrinsic impedance of free space (ohms)
+              #define POLARIZATION__HORIZONTAL    0                       ///< Polarization horizontal

Member

aromanielloNTIA Dec 3, 2024

Please define an enum LFMF::Polarization to handle the polarization values

include/ITS.Propagation.LFMF/LFMF.h Outdated

+              #define POLARIZATION__HORIZONTAL    0                       ///< Polarization horizontal
+              #define POLARIZATION__VERTICAL      1                       ///< Polarization vertical
+              #define METHOD__FLAT_EARTH_CURVE    0                       ///< Flat earth curve method

Member

aromanielloNTIA Dec 3, 2024

Please define an enum LFMF::SolutionMethod to handle the solution method values

include/ITS.Propagation.LFMF/LFMF.h Outdated

+              #define METHOD__RESIDUE_SERIES      1                       ///< Residue series method
+              #define YES                         1                       ///< Find the derivative i.e., Ai'() or Bi'()
+              #define NO                          0                       ///< Find Ai() or Bi()

Member

aromanielloNTIA Dec 3, 2024

Please remove these YES and NO macros, and replace their functionality in Airy.cpp using a simple boolean type for the derivative flag.

include/ITS.Propagation.LFMF/LFMF.h Outdated

+              #define AIRY                        1                       ///< Find the Airy Function
+              #define AIRYD                       2                       ///< Find the Airy function Derivative
+              #define BAIRY                       3                       ///< Find the Bairy Function
+              #define BAIRYD                      4                       ///< Find the Bairy function Derivative

Member

aromanielloNTIA Dec 3, 2024

Please create an enum LFMF::AiryFunctionKind to replace the macros AIRY, AIRYD, BAIRY, BAIRYD, WTWO, DWTWO, WONE, and DWONE based on the following table

Existing Macro	New Enum Member	Definition
`AIRY`	`Ai`	Airy function of the first kind, $Ai(x)$
`AIRYD`	`AiPrime`	Derivative of the Airy function of the first kind, $Ai\prime(x)$
`BAIRY`	`Bi`	Airy function of the second kind, $Bi(x)$
`BAIRYD`	`BiPrime`	Derivative of the Airy function of the second kind, $Bi\prime(x)$
`WTWO`	`WiTwo`	One of Hufford's "Airy functions of the third kind," $Wi^{(2)}(x)$, NTIA TR 87-219 Eq. 38
`DWTWO`	`WiTwoPrime`	The derivative of Hufford's function $Wi^{(2)}(x)$, $Wi\prime^{(2)}(x)$
`WONE`	`WiOne`	One of Hufford's "Airy functions of the third kind," $Wi^{(1)}(x)$, NTIA TR 87-219 Eq. 38
`DWONE`	`WiOnePrime`	The derivative of Hufford's function $Wi^{(1)}(x)$, $Wi\prime^{(1)}(x)$

include/ITS.Propagation.LFMF/LFMF.h Outdated

+              #define WONE                        7                       ///< find Hufford Wi(1) or Wait W1
+              #define DWONE                       8                       ///< find Hufford Wi'(1) or Wait W1'
+              // scaling
+              #define HUFFORD                     9                       ///< Use Hufford scaling

Member

aromanielloNTIA Dec 3, 2024

Please replace macros HUFFORD, WAIT, and NONE with a new enum LFMF::AiryFunctionScaling. Details about what these mean are currently in the docstring for the Airy function in Airy.cpp

cheroy-ntia and others added 11 commits

December 5, 2024 11:27


          enum for int define

ce8f8e4


          update functions inputs

c433954


          update driver inputs

cbf03b1


          clean up

3e6d6f8


          add missing include

9b865ee


          clean up

cc956f6


          update test data and clean up debug lines


          update test data

b5fb8ac


          update test data

03458eb


          Fix CFF validator for Ubuntu 24.04 runner

b235df0


          update CITATION

8e6912f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet