LFMF v1.1 #13
Open
LFMF v1.1 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/include/ReturnCodes.h # app/src/CMakeLists.txt # app/src/ReturnCodes.cpp # app/tests/TestDriver.h
Moves all validation into LFMF_CPP so that nothing gets skipped when using different entrypoints. Previously polarization validation was skipped when using LFMF_CPP
Test cases have been removed that are no longer valid after moving polarization enum validation into LFMF_CPP
Scaling has no effect if kind is AIRY, BAIRY, AIRYD, or BAIRYD. Scaling=NONE should not be used with WONE, WTWO, DWONE, or DWTWO. Instead, only HUFFORD or WAIT scaling should be used for these values of `kind`. Added checks to ensure correct usage at the beginning of the function and removed a condition which this change made irrelevant. Updated documentation.
Use C++ style casts, fix `wofz` rounding differences compared to original implementation
Improve internal error handling, add unit tests for WiRoot and Airy
aromanielloNTIA
added
documentation
Caused errors by default when running driver tests using MSVC. This provides a working default configuration and preset behavior
add driver test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wofzimplementation differ from original algorithm #8,Airy()exits early when inputs specify derivatives of Airy functions of the first or second kind #10, Improve internal error handling, add unit tests for WiRoot and Airy #11)Following this PR, a new v1.1 release will be created.
Note that some links in the README direct to NTIA repositories which are not yet public.