Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carbon emission units [v3.4.42] #250

Merged
merged 14 commits into from
Jul 2, 2024
Merged

Carbon emission units [v3.4.42] #250

merged 14 commits into from
Jul 2, 2024

Conversation

softwareengineerprogrammer
Copy link
Collaborator

  1. Include avoided CO2 emissions in kilotonnes in SHR examples
  2. Change example1_addons emissions unit to kilotonnes from tonnes (since CO2 emissions are typically expressed in kt)
  3. Refactor some unit conversion code to use pint instead of custom logic
  4. Unit test for interim exceptions while currency conversion is disabled (Currency conversions disabled #236)

image

Initially self-reviewed in softwareengineerprogrammer#31

@softwareengineerprogrammer
Convert carbon tonnes using pint instead of hardcoded constant
e3d3da1
@softwareengineerprogrammer
Output total carbon emissions in kilotons for example_SHR-2
b7a6d86
@softwareengineerprogrammer
SHR examples CO2 avoided in kilotonne
46d51a7
@softwareengineerprogrammer
Update example1_addons
9079015
@softwareengineerprogrammer
Remove addressed TODO comment
3c8aa04
@softwareengineerprogrammer
Remove now-unreachable code in ConvertOutputUnits
0c67850
@softwareengineerprogrammer
Unit test disabled currency conversion exceptions (NREL#236)
a9619c3
@softwareengineerprogrammer
Bump version: 3.4.41 → 3.4.42
137cec8
@softwareengineerprogrammer
Use 'true' instead of '1' for Ramey param in SHR examples
aa06df6
@softwareengineerprogrammer
Use 'True' instead of 'true' (True is more pythonic) for Ramey param …
7240944 
…in SHR examples
@softwareengineerprogrammer
Output example1_addons carbon emissions as kilotonne instead of tonne
40cb71c
@softwareengineerprogrammer
Merge pull request #31 from softwareengineerprogrammer/carbon-emissio…
67b68a3 
…n-units

Carbon emission units
@softwareengineerprogrammer
Example text formatting tweaks, SHR well drilling cost comment
b477583
@softwareengineerprogrammer
Fix/update 'CO2 produced by Natural Gas' tooltip text
bbbd3b0
@softwareengineerprogrammer softwareengineerprogrammer marked this pull request as ready for review July 1, 2024 17:27
@softwareengineerprogrammer softwareengineerprogrammer merged commit 21bc007 into NREL:main Jul 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcolm-dsider malcolm-dsider malcolm-dsider approved these changes

@kfbeckers kfbeckers Awaiting requested review from kfbeckers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@softwareengineerprogrammer @malcolm-dsider